Skip to content

MAINT: remove usage of removed astropy functionality _find_home() - #1107

Merged
aphearin merged 2 commits into
astropy:masterfrom
bsipocz:MAINT_remove_find_home_usage
Dec 2, 2024
Merged

aphearin merged 2 commits into
astropy:masterfrom
bsipocz:MAINT_remove_find_home_usage

Conversation

@bsipocz

@bsipocz bsipocz commented Nov 28, 2024

Copy link
Copy Markdown
Member

This should hopefully fix #1106

@bsipocz

bsipocz commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

cc @aphearin - this should be good to go now, and maybe could be included in a quick bugfix release that fixes astropy 7.0 compatibility.

@aphearin

aphearin commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Thanks for this fix @bsipocz! I'm glad you were able to pinpoint this issue with setuptools, and separate this bug from the ongoing unresolved bug with Numpy 2.0 incompatibility, which may take longer to resolve. The source of the Numpy 2.0 incompatibility looks like the way the cython kernels are written, but I haven't gotten to the bottom of that yet. And so since your fix in this PR works in standalone fashion, maybe we should proceed with this merge and then turn attention to the cython/extension-helpers/etc - do you agree?

@bsipocz

bsipocz commented Dec 2, 2024

Copy link
Copy Markdown
Member Author

Yes, I agree that these should be handled separately. Saying that it's not yet numpy2.0 compatible is totally legitimate, but there is no reason for not to be astropy 7 compatible when it's all just silly API cleanups that shouldn't have happened without due notice of downstream.

@aphearin

aphearin commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Great, yes, that's what I thought too - thanks for confirming.

@aphearin
aphearin merged commit d6b485d into astropy:master Dec 2, 2024
@bsipocz
bsipocz deleted the MAINT_remove_find_home_usage branch December 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: compatibility issues with astropy 7.0

2 participants