Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Install pyerfa for astropy dev - #451

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:patch-2
Jul 10, 2020
Merged

bsipocz merged 1 commit into
astropy:masterfrom
pllim:patch-2

Conversation

@pllim

@pllim pllim commented Jul 9, 2020

Copy link
Copy Markdown
Member

To get around CI downstream failing because there is no pyerfa for astropy dev. Also see astropy/astropy#10329

@pllim

pllim commented Jul 9, 2020

Copy link
Copy Markdown
Member Author

I don't think the failures are related.

@pllim

pllim commented Jul 9, 2020

Copy link
Copy Markdown
Member Author

(And I cannot merge this myself.)

@bsipocz

bsipocz commented Jul 9, 2020

Copy link
Copy Markdown
Member

I don't have time to investigate the first failure with pytest-dev version. The second one is trivial, bump the python version or limit mpl in travis for that job.
As for appveryor, for the first failure I would just remove sunpy dev altogether. Given sunpy is not using ci-helpers any more, we could probably nuke it altogether, but that's beyond the scope.

But then the second failure for appveyor is related again.

@pllim

pllim commented Jul 9, 2020 •

Copy link
Copy Markdown
Member Author

My Appveyor-fu isn't strong. How do you tell it to pip install pyerfa instead of trying to look in conda? Although, shouldn't pyerfa be available on conda via Windows, @mhvk or @mwcraig ?

@mhvk

mhvk commented Jul 9, 2020

Copy link
Copy Markdown

I recall discussing that it should go on conda, and that it had been pre-approved, but am not sure how to actually get it there!

@bsipocz

bsipocz commented Jul 10, 2020

Copy link
Copy Markdown
Member

When many months ago I talked to the conda people about it they said they are happy to ship it. But, it first needs a feedstock on conda-forge, so I ping @mwcraig about it.

@bsipocz

bsipocz commented Jul 10, 2020

Copy link
Copy Markdown
Member

please do rebase

@pllim

pllim commented Jul 10, 2020

Copy link
Copy Markdown
Member Author

Hmm, looks like it's on conda-forge already? Then it is a mystery why conda was complaining about not finding it... https://github.com/conda-forge/pyerfa-feedstock

@pllim

pllim commented Jul 10, 2020

Copy link
Copy Markdown
Member Author

Tests passed with pip install.

@mwcraig

mwcraig commented Jul 10, 2020

Copy link
Copy Markdown
Member

Hmm, looks like it's on conda-forge already? Then it is a mystery why conda was complaining about not finding it... https://github.com/conda-forge/pyerfa-feedstock

That is odd. I checked, and it is on both conda-forge and the astropy conda channel.

@pllim

pllim commented Jul 10, 2020

Copy link
Copy Markdown
Member Author

@mwcraig , the log is at https://ci.appveyor.com/project/Astropy/ci-helpers/builds/34011187/job/ddwr46a5l1vu5ytq

PackagesNotFoundError: The following packages are not available from current channels:
  - pyerfa
Current channels:
  - https://repo.anaconda.com/pkgs/main/win-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/win-64
  - https://repo.anaconda.com/pkgs/r/noarch
  - https://repo.anaconda.com/pkgs/msys2/win-64
  - https://repo.anaconda.com/pkgs/msys2/noarch

@pllim

pllim commented Jul 10, 2020

Copy link
Copy Markdown
Member Author

Ooooo maybe ci-helpers CI is not looking in conda-forge...

But then again, people installing astropy from the default conda channel should not be expected to look for pyerfa from non-default, right?

@bsipocz

bsipocz commented Jul 10, 2020

Copy link
Copy Markdown
Member

But then again, people installing astropy from the default conda channel should not be expected to look for pyerfa from non-default, right?

yes. It's deliberate to not use conda-forge here. And it will end up in default when astropy requires it. And in the meantime we can install it from the astropy channel that is a curated subset of conda-forge.

@bsipocz

bsipocz commented Jul 10, 2020

Copy link
Copy Markdown
Member

All green, so let's merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants