Repository navigation
Added script that can be used for tox builds - #429
Conversation
|
Let me know whet this is ready for review. |
26b5abb to
8265248
Compare
|
@bsipocz - ready for review, the Travis failure is unrelated |
|
Travis failure is with the helpers, so I'm rather inclined to patch rework the 4.0 core tag. |
|
@bsipocz - ok sounds good, that does indeed look like the issue that will be fixed in astropy/astropy-helpers#506 - that PR should be ready to be merged |
|
OK, so having the pre release wheels indeed solved the CI. I'll try to do a review later tonight. |
…y apply global patches
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
I am okay with trying this out. 👍
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Look good. It would be nice to have a dummy example of how to limit a dependency version, but given that this is mostly for the few of us maintaining ci-helpers, it's not really necessary.
|
Thanks @astrofrog. And a note to myself that I need to stop saying things about timings that I end up apparently not keeping. |
|
|
|
Oh, right. |
This script installs and run tox, and optionally applies global patches if needed. The idea is to keep this super minimal even in the case where patches need to be applied.
I tried a slightly different approach of leaving it to the caller to actually run the tox command, and using the script to just modify the environment variables, but this didn't work because of issues with quotes in bash, which would require the final tox command to be convoluted.
For now, this script does not do any patching.
I've temporarily disabled all other Travis builds to make sure the one I added works, in case iteration is needed, without wasting CI time.