Repository navigation
remove else clause of resolved PR 6419 - #257
Conversation
ca7098e to
fef0c57
Compare
|
Thanks @kain88-de. However I'm afraid there are still quite a few package out there that I would like to check whether they work before removing this version pinning. I'm away this coming week, once back I'll try to do those checks and come back to this PR. In the meantime the workaround to use newer pytest is to specify the |
|
Yeah I set that as well. Just thought i remove it to follow the instructions of the comment. I’m also OK to wait no hurry. |
|
|
||
| for package in matplotlib sphinx; do | ||
| # ensure pin file exists before moving it | ||
| touch $PIN_FILE |
There was a problem hiding this comment.
It looks like this change means that the pin file isn't always present. Here I'm forcing it to be present. I didn't find anything in the manpage of mv to handle this more gracefully.
There was a problem hiding this comment.
I think it would make sense to have this at the top in L85 after the definition of $PIN_FILE
| hash -r | ||
|
|
||
| set -e | ||
| set -ex |
There was a problem hiding this comment.
I'll remove this again once you give me the OK to handle the PIN_FILE move below like I did.
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Could you please remove the last 4 commits here? Then you need to also update the test file around here: https://github.com/astropy/ci-helpers/blob/master/test_env.py#L12
eb85313 to
6088f8d
Compare
|
I already updated the test file. |
|
Indeed. Thanks. |
already done for travis in astropy#257
astropy/astropy#6419 has been resolved and there is a mark that the else should be removed again.
I saw that when I now noticed that ci-helper don't install the latest version of pytest.