Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Limit pytest version to <3.2.0 - #222

Merged
bsipocz merged 7 commits into
astropy:masterfrom
bsipocz:pytest_pin_lt_3.2.0
Aug 3, 2017
Merged

bsipocz merged 7 commits into
astropy:masterfrom
bsipocz:pytest_pin_lt_3.2.0

Conversation

@bsipocz

@bsipocz bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member

Remove this limitation once astropy/astropy#6419 is fully understood and solved.

cc @astrofrog

@bsipocz

bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member Author

not sure what goes wrong for appveyor, @astrofrog can you spot a typo?

@bsipocz
bsipocz force-pushed the pytest_pin_lt_3.2.0 branch 3 times, most recently from c6b47fa to bd6c33a Compare August 3, 2017 17:11
@bsipocz

bsipocz commented Aug 3, 2017

Copy link
Copy Markdown
Member Author

I'm really out of ideas here, powershell just hates me. @astrofrog @MSeifert04 any ideas how could this be done for appveyor?

@bsipocz
bsipocz force-pushed the pytest_pin_lt_3.2.0 branch from bd6c33a to 915b165 Compare August 3, 2017 18:43
@MSeifert04

MSeifert04 commented Aug 3, 2017 •

Copy link
Copy Markdown

I'm not sure what you want but Write-Host doesn't return anything (just prints to console). Also OutFile clobbers the whole file.

If you just want to create a new file that contains pytest <3.2 (+newline) just use

"pytest <3.2" | Out-File path_to_file

@bsipocz

bsipocz commented Aug 3, 2017 •

Copy link
Copy Markdown
Member Author

@MSeifert04 - Thanks. My last commit was a bit misleading, I kept amending my trials, I've started off without the pin file to have the limitation in the conda install line (weirdly it didn't work for py2.7, but was fine for the first build for 3.6), then tried all sorts of quoting, echo, etc, then remembered that powershell is a beast and has a few specific command...

@bsipocz
bsipocz merged commit 3ee487c into astropy:master Aug 3, 2017
@MSeifert04

Copy link
Copy Markdown

as long as it works 👍 :)

@bsipocz

bsipocz commented Aug 3, 2017

Copy link
Copy Markdown
Member Author

yes, it's a shame to do it this way but I'm not willing to properly dig into and learn the mess of powershell 😉

@bsipocz

bsipocz commented Aug 4, 2017

Copy link
Copy Markdown
Member Author

Hmm, it didn't work and now I'm back at the same pit I was yesterday with those weird characters

https://ci.appveyor.com/project/Astropy/ci-helpers/build/1.0.757/job/reutxgf6nx7e7wji#L267

@MSeifert04

MSeifert04 commented Aug 4, 2017 •

Copy link
Copy Markdown

Ah, that's just some encoding issue, you could use "pytest <3.2" | Out-File ... -Encoding ASCII.

@bsipocz

bsipocz commented Aug 4, 2017

Copy link
Copy Markdown
Member Author

At the end I used the super ugly hack of copying over a canned version of that file from here. There are no words to describe how much I dislike powershell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants