Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Unfixed coverage version to use latest one - #132

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:rm-fixed-cov
Oct 10, 2016
Merged

bsipocz merged 1 commit into
astropy:masterfrom
pllim:rm-fixed-cov

Conversation

@pllim

@pllim pllim commented Sep 8, 2016

Copy link
Copy Markdown
Member

Unfixed coverage version to use latest one (currently 4.2 from conda).

This is to possibly fix the timing problem in astropy/astropy#4826.

c/c @mhvk @MSeifert04

@mhvk

mhvk commented Sep 8, 2016

Copy link
Copy Markdown

This looks good, but my one question is how to test the problems with previous 4.x versions have gone away... Should we just merge and see if any affiliated package starts complaining? This may be the only feasible way, but then perhaps it is a good idea to send a note to the mailing list...

Alternatively, but maybe too much work, if one can override the package (or reinstall it) in .travis.yml, we could try it in astropy/astropy#5308

@pllim

pllim commented Sep 8, 2016

Copy link
Copy Markdown
Member Author

My travis-fu is not that strong. Perhaps @astrofrog or @bsipocz can suggest a way...

@bsipocz

bsipocz commented Sep 8, 2016

Copy link
Copy Markdown
Member

I recall that there were some previous problems, that's why we froze the version numbers here. So I suggest to double check it with a few mock branches for at least astropy core (and maybe a few affiliated packages like gammapy that saw the issue) before merging this. Generally we try not to experiment much in the master ci-helpers is avoidable by doing testing first.
I'll try to have a look at this later tonight.

@pllim

pllim commented Sep 8, 2016

Copy link
Copy Markdown
Member Author

Thanks, @bsipocz !

@bsipocz

bsipocz commented Sep 27, 2016

Copy link
Copy Markdown
Member

@pllim - Could you please rebase this? (As a safeguard PRs in ci-helpers always needs to be against the latest master, so whenever the master changes everything needs to be rebased and retested. before github allows to push the merge button.)

@pllim

pllim commented Sep 27, 2016

Copy link
Copy Markdown
Member Author

@bsipocz , rebased and passed.

@bsipocz

bsipocz commented Oct 10, 2016

Copy link
Copy Markdown
Member

It looks like that coverage runs with the new version, both in astropy and gammapy, so I'm happy to merge this asap.
(Although I get some failures in the test builds, I think those are unrelated and should go away once the build is run in its repository and not in my fork: https://travis-ci.org/bsipocz/astropy/builds/166497095)

@pllim - Could you please rebase it one last time?

@pllim

pllim commented Oct 10, 2016

Copy link
Copy Markdown
Member Author

@bsipocz , rebased and passed.

@bsipocz
bsipocz merged commit 22230a9 into astropy:master Oct 10, 2016
@bsipocz

bsipocz commented Oct 10, 2016

Copy link
Copy Markdown
Member

Hurray, thanks @pllim.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants