This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Installing wrong version of packages #98
Description
This was first reported in astropy/astropy#5094 (comment), the install process erroneously picked up the wrong numpy version (1.9.0b1) from the astropy-ci-extras conda channel rather than a stable released version (e.g. 1.9.3) from the default conda channel.
There are several issues with this, first we should never pick up a beta release unless asked for it with NUMPY_VERSION=prerelease. Also we should always pick up the latest available version of a given package.
As a side feature request: would be nice to find a way to specify the priority order of conda channels for cases when a package is available in several ones.
Activity
astrofrog commentedon Jun 15, 2016
I feel like astropy-ci-extras shouldn't be providing pre-releases of packages for this reason. When did we start adding these? This broke a number of builds for some other projects of mine too.
If we really want to provide pre-releases, I feel like a different channel would be more appropriate.
A quick workaround is to delete all pre-releases from astropy-ci-extras.
cc @mwcraig
bsipocz commentedon Jun 15, 2016
I think that happened a very long time ago, hardly any updates were made to that channel. My initial workaround is to remove it from the default channels for now.
pllim commentedon Jun 15, 2016
I wish I saw this sooner! I had been scratching my head at this failure and finally had to manually pin Numpy to 1.10 to get the tests to pass.
Minor removing astropy-ci-extras while we investigate #98
bsipocz commentedon Jun 15, 2016
@astrofrog - It seems that we've been using ci-extras quite frequently, as for e.g. np 1.8 the latest conda astropy is v0.4.
I'm not sure though that testing affiliated packages for
stableastropy with v1.0.3 is any better (e.g. the latest onastropy-ci-helpersfor np 1.8).mwcraig commentedon Jun 15, 2016
I don't recall why 1.9.0b1 was added to the channel, but I
can delete it easily. Actually, don't seem to have that superpower on anaconda.org/astropy-ci-extras.I'm guessing this is causing problems now because of the conda issue @astrofrog turned up (conda/conda#2675).
@astrofrog or someone else with the appropriate super-powers, could you please add a repo to the astropy org on github called
conda-channel-ci-extras? We can then hash out what matrix of versions and packages we want in that channel and get it populated. If there is a desire for any pre-release stuff we can change the label from "main" to something else (pre?) and it won't be picked up just by using the channel.larrybradley commentedon Jun 16, 2016
It appears
travis-ciis having issues again becausenumpy 1.9.0b1is being installed fromastropy-ci-extras:https://travis-ci.org/astropy/photutils/builds/137972366
astrofrog commentedon Jun 16, 2016
I just removed numpy 1.9.0b1 from astropy-ci-extras, can you restart the build?
larrybradley commentedon Jun 16, 2016
Restarting now....
astrofrog commentedon Jun 16, 2016
@mwcraig - done: https://github.com/astropy/conda-channel-ci-extras
astrofrog commentedon Jun 16, 2016
However, I think we should consider carefully whether we really want to maintain astropy-ci-extras in future. The defaults conda channel already now provides an incomplete matrix of versions, but maybe that's enough - maybe we just need to document better which versions can be used together. For example, Astropy 0.4 can be installed with Numpy 1.8 and 1.9. To some extent, I don't know if we need to worry about combinations not provided by the defaults channel, because it means the versions were not co-eval, so they are not common set-ups.
astrofrog commentedon Jun 16, 2016
Just for some background, we started astropy-ci-extras when conda was still quite new and there wasn't such a range of versions available.
larrybradley commentedon Jun 16, 2016
@astrofrog The tests are now failing because
numpy 1.5.1(!) is being installed fromastropy-ci-extras:https://travis-ci.org/astropy/photutils/jobs/137972381#L462
larrybradley commentedon Jun 16, 2016
Mysteriously, that line now says
numpy-1.9.0b1(was I too fast to restart or doestravis-cicache packages?), but I swear it said1.5.1!larrybradley commentedon Jun 16, 2016
It did it again. The
travis-cilog originally saidnumpy 1.5.1:but now it says
numpy 1.9.0b1.In any case, now more tests are failing from
numpyversion weirdness:https://travis-ci.org/astropy/photutils/builds/137972366
8 remaining items
mwcraig commentedon Jun 16, 2016
@astrofrog -- I agree that at a minimum the current channel should be cleared out, and repopulated only when and if we have a clear idea of what it is supposed to do.
My understanding is that its only purpose is to provide numpy/astropy for CI purposes for combinations that continuum doesn't build, and that only to save the time of building numpy (and to a lesser extent astropy) each time. So its purpose ins't to provide conda packages for users, it is just to make it easier to test some of the older python/numpy combinations.
If we don't need to do that because of the recent changes you made to the build matrix then maybe we don't need to do this.
larrybradley commentedon Jun 16, 2016
conda4.1.1 is now available as a conda package.mwcraig commentedon Jun 16, 2016
@larrybradley -- can you try restarting one of the photutils builds that were failing and let's see what happens?
larrybradley commentedon Jun 16, 2016
Already running. 😄
larrybradley commentedon Jun 16, 2016
Done, actually. It still failed:
https://travis-ci.org/astropy/photutils/jobs/137972377
larrybradley commentedon Jun 16, 2016
The failure appears to be because of the issue with
astropy 1.0.1that @bsipocz mentioned above.mwcraig commentedon Jun 16, 2016
How painful would it be to change the travis config to pip install astropy (instead of conda install) for that case?
astrofrog commentedon Jun 16, 2016
@mwcraig - should be as easy as just putting
astropyinPIP_DEPENDENCIESand not specifyingASTROPY_VERSIONmwcraig commentedon Jun 21, 2016
@astrofrog -- could you please give me write or administrative privileges on:
Currently leaning towards populating this with channel with only:
eteq commentedon Jun 21, 2016
@mwcraig - I changed it so that the "conda build maintainers" (which includes you and @bsipocz) have admin on "conda-channel-ci-extras"
(I don't have control over anaconda.org, though)
astrofrog commentedon Jun 21, 2016
@mwcraig @eteq - I sent you both the astropy-ci-extras details with PGP encryption
astrofrog commentedon Jun 21, 2016
@bsipocz - this is fixed too hopefully?
bsipocz commentedon Jun 21, 2016
I'm closing this as we now have the fallback to pip when the astropy version gets messed up terribly, and dealing with ci-extras is a different issue.