Skip to content

Median filter wrapper - #420

Merged
mwcraig merged 4 commits into
astropy:masterfrom
MSeifert04:median_filter_wrapper
Nov 17, 2016
Merged

Median filter wrapper#420
mwcraig merged 4 commits into
astropy:masterfrom
MSeifert04:median_filter_wrapper

Conversation

@MSeifert04

@MSeifert04 MSeifert04 commented Nov 16, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please have a look at the following list and replace the "[ ]" with a "[x]" if
the answer to this question is yes.

  • For new contributors: Did you add yourself to the "Authors.rst" file?

For documentation changes:

  • For documentation changes: Does your commit message include a "[skip ci]"?
    Note that it should not if you changed any examples!

For bugfixes:

  • Did you add an entry to the "Changes.rst" file?
  • Did you add a regression test?
  • Does the commit message include a "Fixes #issue_number" (replace "issue_number").
  • Does this PR add, rename, move or remove any existing functions or parameters?

For new functionality:

  • Did you add an entry to the "Changes.rst" file?
  • Did you include a meaningful docstring with Parameters, Returns and Examples?
  • Does the commit message include a "Fixes #issue_number" (replace "issue_number"): Fixes Adding 'median' function #371
  • Did you include tests for the new functionality?
  • Does this PR add, rename, move or remove any existing functions or parameters?

Please note that the last point is not a requirement. It is meant as a check if
the pull request potentially breaks backwards-compatibility.

@MSeifert04 MSeifert04 added this to the 1.2 milestone Nov 16, 2016
@MSeifert04

MSeifert04 commented Nov 16, 2016

Copy link
Copy Markdown
Contributor Author

This is the simple wrapper alternative for #415. Please do not close the other PR if this is merged. I rather hope an extended support_nddata wrapper would make sense for several functions (including block_reduce, ...).

mwcraig
mwcraig requested changes Nov 17, 2016
View reviewed changes

@mwcraig mwcraig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSeifert04 -- the content of the PR itself looks fine to me. Could you please add a bit to the narrative documentation about median_filter?

@mwcraig

mwcraig commented Nov 17, 2016

Copy link
Copy Markdown
Member

Thanks, feel free to merge when the lights turn green.

@MSeifert04

MSeifert04 commented Nov 17, 2016

Copy link
Copy Markdown
Contributor Author

I've added a new section to the reduction toolbox (that was what you meant, right?):

unbenannt

@MSeifert04

MSeifert04 commented Nov 17, 2016

Copy link
Copy Markdown
Contributor Author

@mwcraig You're fast. 😄

@mwcraig

mwcraig commented Nov 17, 2016

Copy link
Copy Markdown
Member

Thanks, merging.

@mwcraig
mwcraig merged commit 8a9f820 into astropy:master Nov 17, 2016
@MSeifert04
MSeifert04 deleted the median_filter_wrapper branch November 18, 2016 04:58
@MSeifert04

MSeifert04 commented Nov 18, 2016

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwcraig mwcraig mwcraig approved these changes

Assignees

No one assigned

Labels

ccdproc enhancement

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

Adding 'median' function

2 participants

@MSeifert04 @mwcraig