Repository navigation
trim_image calls CCDData slicing even if fits_section is given. - #282
Merged
Merged
Conversation
Member
|
Thanks for the contribution @MSeifert04 ! I'm just thinking about whether this needs any tests as it was addressing a specific issue, but since there is already a WCS test in the unit tests and the NAXIS issue is an astropy.wcs issues, I don't think so. Also since no functionality is changed, it doesn't need a changelog, so I'll test it out and then merge it. |
Contributor
Author
|
@crawfordsm Sorry I was a bit sparse with the details: Since it wasn't found out as a bug I did not add it to the changelog. With test cases I wasn't sure since the only difference was with the |
Member
|
Thanks @MSeifert04 -- merging |
crawfordsm
added a commit
that referenced
this pull request
Jan 16, 2016
trim_image calls CCDData slicing even if fits_section is given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a discussion in #281 (comment).
I think it would be best to rely on
CCDData.__getdata__instead of trying to the same inside thetrim_imagefunction itself.