Skip to content

Adding 'median' function #371

Closed
Closed

Description

@AlexaVillaume

This is a continuation of what was discussed in issue #370.

I'm going to try to recreate the IRAF task 'median'. I imagine it as essentially being a wrapper to the scipy medfilt2 function.

I'm new to contributing so any suggestions about how best to proceed are welcome!

Activity

  1. mirca commented on Jul 7, 2016

    @mirca
    Member

    Hi @AlexaVillaume,

    if you haven't contributed to astropy before, you might want to take a look at How to make a code contribution .

    Best =)

  2. added this to the 1.1 milestone on Jul 7, 2016
  3. crawfordsm commented on Jul 7, 2016

    @crawfordsm
    Member

    A median function would be a great place to start and it sounds like like wrapping the scipy function would work well. If you have any questions or would like any help with the intermediate steps, please feel free to post here about any of the steps.

    For overall development workflow, the link above is a good place to start. For ccdproc, I'd suggest taking a look at the functions in core.py in ccdproc for examples of how functions should look like or work. Some ones that might be good to look at are transform_image or rebin.

    Once you have some code, please make a pull request and we will be happy to discuss it and work through the process if needed.

  4. mwcraig commented on Jul 7, 2016

    @mwcraig
    Member

    @AlexaVillaume -- good to hear from you! One other place to look is in combine.py. I've never used IRAF so I'm not sure what it's median does, but there are some median options for combining already.

    The big thing to make sure you do is to create a git branch to work on before you make changes. That makes it infinitely easier to fix any issues down the road.

  5. modified the milestones: 1.2, 1.1 on Jul 19, 2016
  6. pllim commented on Sep 8, 2016

    @pllim
    Member

    I think @saraogaz and @justincely would be interested in this as well.

  7. self-assigned this
    on Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions