Skip to content

Adding python 3.6 to CI builds - #815

Merged
bsipocz merged 5 commits into
astropy:masterfrom
bsipocz:travis_add_python36
Mar 29, 2017
Merged

Adding python 3.6 to CI builds#815
bsipocz merged 5 commits into
astropy:masterfrom
bsipocz:travis_add_python36

Conversation

@bsipocz

@bsipocz bsipocz commented Dec 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Probably we need to wait a bit more until all the dependencies become available on python 3.6.

Edit: this is now based on #869

@bsipocz bsipocz added this to the 0.3.5 milestone Dec 29, 2016
@bsipocz
bsipocz force-pushed the travis_add_python36 branch 2 times, most recently from 0a2010d to 83160f8 Compare January 25, 2017 14:35
@bsipocz

bsipocz commented Jan 25, 2017

Copy link
Copy Markdown
Member Author

It seems that we have genuine incompatibilities with py3.6:
https://travis-ci.org/astropy/astroquery/jobs/195195678

@keflavich

keflavich commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

Apparently py3.6 doesn't support \s as a generic whitespace character any more? That doesn't show up in the changelog... https://docs.python.org/3.6/whatsnew/3.6.html#re

@keflavich

keflavich commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

Or... \s was always ignored, and now py3.6 is actually telling us: https://docs.python.org/3/library/re.html#regular-expression-syntax "Changed in version 3.6: Unknown escapes consisting of '\' and an ASCII letter now are errors."

@bsipocz

bsipocz commented Jan 25, 2017

Copy link
Copy Markdown
Member Author

Maybe it's enough to add an r in front of the strings, as it was done for astropy https://github.com/astropy/astropy/pull/5489/files

@bsipocz

bsipocz commented Jan 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

OK, so there is one more error left. It seems to be an upstream pytest issue, and while we use the astropy bundled version there isn't a chance to avoid it. (Also it's not yet fixed in pytest itself as of pytest-dev/pytest#2160, so it would probably best to find a fix here for now).

I'm not 100% sure, but it seems that using unittest triggers the error, as it's only the esasky module that uses it.

==================================== ERRORS ====================================

_ ERROR collecting lib.linux-x86_64-3.6/astroquery/esasky/tests/test_esasky.py _

_pytest.runner:149: in __init__

    ???

_pytest.main:431: in _memocollect

    return self._memoizedcall('_collected', lambda: list(self.collect()))

_pytest.main:311: in _memoizedcall

    res = function()

_pytest.main:431: in <lambda>

    return self._memoizedcall('_collected', lambda: list(self.collect()))

_pytest.python:600: in collect

    ???

_pytest.python:454: in collect

    ???

_pytest.python:466: in makeitem

    ???

_pytest.vendored_packages.pluggy:724: in __call__

    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)

_pytest.vendored_packages.pluggy:338: in _hookexec

    return self._inner_hookexec(hook, methods, kwargs)

_pytest.vendored_packages.pluggy:333: in <lambda>

    _MultiCall(methods, kwargs, hook.spec_opts).execute()

_pytest.vendored_packages.pluggy:595: in execute

    return _wrapped_call(hook_impl.function(*args), self.execute)

_pytest.vendored_packages.pluggy:249: in _wrapped_call

    wrap_controller.send(call_outcome)

E   DeprecationWarning: generator 'pytest_pycollect_makeitem' raised StopIteration

This was referenced Jan 26, 2017
Closed
Merged
@bsipocz
bsipocz force-pushed the travis_add_python36 branch from dddef16 to f6c2dd2 Compare February 15, 2017 15:24
@bsipocz
bsipocz force-pushed the travis_add_python36 branch 2 times, most recently from 75d613b to 3cb2188 Compare March 20, 2017 22:36
@bsipocz

bsipocz commented Mar 20, 2017

Copy link
Copy Markdown
Member Author

This now includes #864 to fix most of the deprecations.

@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 3cb2188 to 1a586c9 Compare March 20, 2017 23:58
@bsipocz

bsipocz commented Mar 21, 2017

Copy link
Copy Markdown
Member Author

@keflavich - This can't be merged until the unittests are sorted out. However, since the unittest issue affects only the tests, we can make 0.3.5 py3.6 compatible if I factor out the docstring and other py3.6 related changes from here. Should we do that?

@keflavich

keflavich commented Mar 21, 2017 via email

Copy link
Copy Markdown
Contributor

@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 1a586c9 to 753531d Compare March 21, 2017 14:42
@bsipocz bsipocz mentioned this pull request Mar 21, 2017
Merged
@bsipocz bsipocz modified the milestones: 0.3.6, 0.3.5 Mar 21, 2017
@aphearin aphearin mentioned this pull request Mar 28, 2017
Closed
@bsipocz bsipocz mentioned this pull request Mar 28, 2017
Closed
@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 753531d to 6e7a985 Compare March 28, 2017 15:41
@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 6e7a985 to d05f5c6 Compare March 28, 2017 19:57
@bsipocz bsipocz modified the milestones: 0.3.5, 0.3.6 Mar 29, 2017
@bsipocz

bsipocz commented Mar 29, 2017

Copy link
Copy Markdown
Member Author

Merging as finally this passed (except the coverage where something is really badly broken somewhere unrelated to this PR).

@bsipocz
bsipocz merged commit 82df5d4 into astropy:master Mar 29, 2017
@bsipocz
bsipocz deleted the travis_add_python36 branch April 6, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog-entry-needed testing

Projects

None yet

Milestone

0.3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@bsipocz @keflavich