Repository navigation
Conversation
Six Parameters entries name an argument the function does not take, one of them a plain typo (raidus). Docstrings only.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 230 230
Lines 21354 21354
=======================================
Hits 15679 15679
Misses 5675 5675 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Six
Parametersentries name an argument the function does not take. Each was read against its signature before changing.astroquery/ipac/irsa/core.py:142query_ssaraidusradius— a typo; the description below it already says "the radius of the circular region"astroquery/ipac/irsa/irsa_dust/utils.py:80find_result_nodexmlTreexml_treeastroquery/ipac/ned/core.py:506_extract_image_urlsformatfile_formatastroquery/linelists/cdms/core.py:619CDMSClass.findsst(the summary line above still reads "regex match to string s")astroquery/mast/services.py:252_parse_resultresponsesresponseastroquery/mast/utils.py:533parse_numeric_product_filtervalvalsraidusis the one users would actually hit: it is a public method, so the rendered docs offer a keyword that raisesTypeErrorif copied.Docstrings only — no signature, call site, or behaviour is touched.
Not included
The same sweep raised twenty more of this kind, spread across
cadc,cosmosim,esa/hubble,esa/iso,esa/xmm_newton,mocserver,vizier,wfauand others. I kept this PR to the six that are unambiguous single-name mismatches rather than opening one that touches nine subpackages at once. Happy to send the rest, split per subpackage if you prefer.Two I deliberately left alone:
astroquery/template_module/core.pydocumentsverboseandany_other_paramthat the template's own signature does not have — but that file is the worked example for new modules, so the placeholders read as intentional.astroquery/esa/utils/utils.py:505__create_adql_criteriadocumentsquery_criteriaagainst afiltersparameter; that one looked like it might be a genuine rename in progress rather than a stale tag, and I did not want to guess.