Skip to content

TST: utils monkeypatch compatibility with astropy 4.1/4.0.2 - #1711

Merged
keflavich merged 1 commit into
astropy:masterfrom
pllim:fix-monkeypatch
Apr 29, 2020
Merged

keflavich merged 1 commit into
astropy:masterfrom
pllim:fix-monkeypatch

Conversation

@pllim

@pllim pllim commented Apr 29, 2020

Copy link
Copy Markdown
Member

Fix astropy/astropy#10227

Tests passed locally with astropy 4.1.dev and 4.0.1.post1 but I only ran:

python setup.py test -P utils --remote-data

xref: astropy/astropy#9964

@astropy-bot astropy-bot Bot added the utils label Apr 29, 2020
@pllim pllim changed the title TST: utils monkeypatch compatibility with astropy 4.1 TST: utils monkeypatch compatibility with astropy 4.1/4.0.2 Apr 29, 2020
@codecov

codecov Bot commented Apr 29, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #1711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1711   +/-   ##
=======================================
  Coverage   63.10%   63.10%           
=======================================
  Files         195      195           
  Lines       15247    15247           
=======================================
  Hits         9621     9621           
  Misses       5626     5626           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5076ec5...1e1462d. Read the comment docs.

@bsipocz

bsipocz commented Apr 29, 2020

Copy link
Copy Markdown
Member

Given this is testing internal only, I don't think a changelog is needed.

Thanks a million @pllim for the fix on this very short timescale!

@keflavich
keflavich merged commit cd99f02 into astropy:master Apr 29, 2020
@pllim
pllim deleted the fix-monkeypatch branch April 29, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change in default data download handling breaks astroquery

3 participants