Skip to content

Preparing for tagging 0.4 - #1607

Merged
bsipocz merged 6 commits into
astropy:masterfrom
bsipocz:pre_0.4_remote_maintenance
Jan 25, 2020
Merged

Preparing for tagging 0.4#1607
bsipocz merged 6 commits into
astropy:masterfrom
bsipocz:pre_0.4_remote_maintenance

Conversation

@bsipocz

@bsipocz bsipocz commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This PR is a collection of various cleanups in prep for tagging 0.4

Current content:

  • fixes for various remote test failures
  • fixing pytest headers
  • updating astropy-helpers

@bsipocz bsipocz added this to the v0.4 milestone Dec 26, 2019
@bsipocz
bsipocz force-pushed the pre_0.4_remote_maintenance branch from e20a4c8 to 2658557 Compare December 26, 2019 23:20
@codecov

codecov Bot commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1607   +/-   ##
=======================================
  Coverage   62.93%   62.93%           
=======================================
  Files         185      185           
  Lines       14979    14979           
=======================================
  Hits         9427     9427           
  Misses       5552     5552

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16470e...161ff8a. Read the comment docs.

@bsipocz
bsipocz force-pushed the pre_0.4_remote_maintenance branch from e0add53 to 4cd790e Compare December 27, 2019 00:31
@bsipocz bsipocz mentioned this pull request Jan 4, 2020
Closed
@bsipocz
bsipocz force-pushed the pre_0.4_remote_maintenance branch from 4cd790e to 70e3c38 Compare January 9, 2020 00:42
@bsipocz
bsipocz force-pushed the pre_0.4_remote_maintenance branch from 70e3c38 to a389351 Compare January 22, 2020 23:36
@bsipocz bsipocz mentioned this pull request Jan 23, 2020
Merged
@bsipocz
bsipocz force-pushed the pre_0.4_remote_maintenance branch from a389351 to 161ff8a Compare January 25, 2020 00:26
@bsipocz

bsipocz commented Jan 25, 2020

Copy link
Copy Markdown
Member Author

We're down to a very low number of remote failures, so I'll call it a day and make v0.4.
This are the ones failing locally for me:

astroquery/cds/tests/test_mocserver.py ..........                                                                                       
astroquery/cds/tests/test_mocserver_remote.py .........F...                                                                             
astroquery/esasky/tests/test_esasky.py ....                                                                                             
astroquery/esasky/tests/test_esasky_remote.py ..x.xFF.                                                                                  
astroquery/oac/tests/test_oac.py .........                                                                                              [ 
astroquery/oac/tests/test_oac_remote.py F...F.X.X..

The cds one is just an issue with the test (see #1608), esasky has some real looking votable issues, and oac has some real looking json issues.

@bsipocz
bsipocz merged commit 161dd42 into astropy:master Jan 25, 2020
@bsipocz

bsipocz commented Jan 25, 2020

Copy link
Copy Markdown
Member Author

While all CI was green here, after the merge master has a failure. It seems unrelated, and very similar to this travis one: travis-ci/travis-ci#8920, so I'll go ahead with the release.
I'll investigate into the details if the failure is persistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cadc no-changelog-entry-needed skyview

Projects

None yet

Milestone

v0.4

Development

Successfully merging this pull request may close these issues.

1 participant

@bsipocz