Repository navigation
Add OGLE-III interstellar extinction calculator query - #124
Conversation
There was a problem hiding this comment.
missing closing parentheses
There was a problem hiding this comment.
Thanks, good eye. I threw that in below.
There was a problem hiding this comment.
Can make this a link by doing:
``hosted here http://ogle.astrouw.edu.pl/cgi-ogle/getext.py_
|
This is looking good. I can merge any time, but I submitted a series of fairly minor requests, mostly on general documentation and coding form. |
|
Great, thanks for taking a look! Those comments are helpful. I'll add another comment when I've made all of them. |
|
Ok, I've implemented the suggestions. Things should be good to merge. Thanks |
|
Alright, this looks good and I'll go ahead and merge it. There is one more thing it would be really helpful if you could do: modify the tests such that there are both remote and non-remote tests, e.g. using monkey-patching as in IRSA: But, this should be a separate pull request. Thanks! |
Add OGLE-III interstellar extinction calculator query
I've made a first pass implementation of the OGLE-III extinction calculator (http://ogle.astrouw.edu.pl/). With the aim to include other extinction queries, I think this is a first step, and at a later date a wrapper can be made to combine all the extinction related queries.
The module currently doesn't meet the full API, but it includes a docs page, doc strings, and should meet the general API guidelines. The module doesn't need to store state and only executes one query, so it should be simple to refactor at a future date.
There is a hack-y function
ogle._parse_coordsto implement searches with 1) oneastropy.coordinatesinstance, 2) a list ofastropy.coordinatesinstances, or 3) a 2xN list of lons and lats as strings or floats.Thanks in advance for any code review