Add all optional kwargs of BaseQuery to the modules #1233

Activity

1. bsipocz

   added

   package-novice

   effort-medium

   infrastructure

   on Sep 12, 2018
2. kakirastern commented on Mar 18, 2019

   

   kakirastern

   on Mar 18, 2019

   Contributor

   More actions

   Hi @bsipocz, is it okay for me to work on this issue in preparation for GSoC? Or should I pick something more difficult at this stage?
3. bsipocz commented on Mar 18, 2019

   

   bsipocz

   on Mar 18, 2019

   MemberAuthor

   More actions

   No, this is perfectly fine and actually very useful to have!
4. kakirastern commented on Mar 18, 2019

   

   kakirastern

   on Mar 18, 2019

   Contributor

   More actions

   Yup, that's awesome. Will start with this then for me to get familiar with the astroquery codebase...
5. bsipocz commented on Mar 18, 2019

   

   bsipocz

   on Mar 18, 2019

   MemberAuthor

   More actions

   Getting familiarity with BaseQuery will go a long way as the preferred GSoC project will most probably involve improving it.
6. kakirastern commented on Mar 18, 2019

   

   kakirastern

   on Mar 18, 2019

   Contributor

   More actions

   Yeah, it is true...
7. kakirastern commented on Mar 30, 2019

   

   kakirastern

   on Mar 30, 2019

   Last edited by kakirastern

   Contributor

   More actions

   1st Batch

   Strategy: Will commit only one module first in order for reviewer to check the work, then extend to other modules in alphabetical order where possible. Starting with the subset of modules which follow a common API, as listed below:

   • alma/alma
   • atomic/atomic
   • besancon/besancon
   • cds/cds
   • esasky/esasky
   • eso/eso
   • gaia/gaia
   • gama/gama
   • heasarc/heasarc
   • hitran/hitran
   • ibe/ibe
   • irsa/irsa
   • irsa/irsa_dust
   • jplspec/jplspec
   • magpis/magpis
   • mast/mast
   • mpc/mpc
   • nasa_ads/nasa_ads
   • ned/ned
   • nist/nist
   • nrao/nrao
   • nvas/nvas
   • simbad/simbad
   • skyview/skyview
   • splatalogue/splatalogue
   • ukidss/ukidss
   • vamdc/vamdc
   • vizier/vizier
   • vo_conesearch/vo_conesearch
   • vsa/vsa
   • xmatch/xmatch

   2nd Batch
   Modules which are functional, but do not follow a common & consistent API:

   • alfalfa
   • cosmosim
   • exoplanet_orbit_database
   • fermi
   • jplhorizons/horizons
   • jplsbdb/sbdb
   • lamda
   • nasa_exoplanet_archive
   • oac
   • ogle
   • open_exoplanet_catalogue
   • sdss
   • sha

   3rd Batch
   Subpackages which serve as the basis of others

   • wfau
8. bsipocz commented on Mar 30, 2019

   

   bsipocz

   on Mar 30, 2019

   MemberAuthor

   More actions

   @kakirastern - I would suggest to keep the note to self comments in issues and PRs to minimum. You can add them to a personal project board, wiki page, google docs, or any other means to track your work.
   I know it's difficult to find the balance, but given that there are plenty people watching the different repositories as it's quite distractive to receive notifications for these entries.
9. kakirastern commented on Mar 30, 2019

   

   kakirastern

   on Mar 30, 2019

   Contributor

   More actions

   @bsipocz Sure, I will try to keep to note to self comments to a minimum.
10. kakirastern commented on Apr 3, 2019

    

    kakirastern

    on Apr 3, 2019

    Contributor

    More actions

    Hi, just wanted to double-check that I will need to have added the list of keywords for _request in the BaseQuery class as self, method, url, params, data, headers, files, save, savedir, timeout, cache, stream, auth, continuation, verify, and I better use the default values as listed in the code snippet:

    def _request(self, method, url, params=None, data=None, headers=None,
                     files=None, save=False, savedir='', timeout=None, cache=True,
                     stream=False, auth=None, continuation=True, verify=True): ... 
    

    and similar for _download_file as in

    def _download_file(self, url, local_filepath, timeout=None, auth=None,
                           continuation=True, cache=False, method="GET",
                           head_safe=False, **kwargs): ...
    

    And, these are to be applied consistently to all modules. If I have made any mistakes above please correct me. Thanks!
11. kakirastern commented on Apr 18, 2019

    

    kakirastern

    on Apr 18, 2019

    Contributor

    More actions

    PR #1419 opened to address this issue.