Repository navigation
Filter out astropy core package from pyOpenSci Affiliated listing - #699
Conversation
hamogu
left a comment
hamogu
left a comment
There was a problem hiding this comment.
I still see it listed. Is the name "astropy" or did PyOpenSci names it "astropy core package" (which doesn't trigger the continue statement)?
|
I also think the "maintainers" entry is not right but since our goal is not display the core package at all in this list, we don't have to worry about that at this point. |
|
@hamogu , I don't think my code touches Coordinated Packages listing at https://www.astropy.org/affiliated/index.html#coordinated-package-list I think changing this one is out of scope here and should be done in a separate PR? astropy.github.com/affiliated/registry.json Line 120 in ed29abb |
|
Thanks for the merge, @hamogu . Do you want me to open follow-up PR for Coordinated listing you pointed out at #699 (review) ? |
because somehow it is lost
Fix #695
Before: https://www.astropy.org/affiliated/index.html#affiliated-package-list
After: https://output.circle-artifacts.com/output/job/4dd10e93-e453-4308-86a9-1caf4f472f6b/artifacts/0/html/affiliated/index.html#affiliated-package-list