Skip to content

Add asdf-astropy as a coordinated package - #490

Merged
pllim merged 3 commits into
astropy:mainfrom
WilliamJamieson:add_asdf-astropy
Jun 2, 2022
Merged

pllim merged 3 commits into
astropy:mainfrom
WilliamJamieson:add_asdf-astropy

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented May 10, 2022 •

Copy link
Copy Markdown
Contributor

Following the discussion at today's Astropy dev telecon, it was decided that asdf-astropy should be made a coordinated package given that the functionality provided by astropy.io.misc.asdf is being moved from the astropy core to this package.

Tagging @pllim and @dhomeier

@WilliamJamieson

Copy link
Copy Markdown
Contributor Author

Tagging @nden and @perrygreenfield to confirm they will be maintainers.

@nden

nden commented May 10, 2022

Copy link
Copy Markdown
Contributor

I am OK with being a maintainer

@pllim

This comment was marked as resolved.

@dhomeier

Copy link
Copy Markdown
Contributor

I suggest to add a CITATION file to the repo as well.

@pllim

pllim commented May 12, 2022 •

Copy link
Copy Markdown
Member

Thank you for proposing this package as an affiliated a coordinated package! I'm happy to confirm that your package is now under review and we'll post the results of the review here and on the mailing list.

@pllim pllim self-assigned this May 18, 2022
Comment thread affiliated/registry.json Resolved
@perrygreenfield

Copy link
Copy Markdown
Member

I confirm that I will be a maintainer.

@pllim

pllim commented May 19, 2022

Copy link
Copy Markdown
Member

This package has been reviewed for inclusion in the Astropy affiliated coordinated package ecosystem by yours truly, and I have synthesized the results of the review here.

You can find out more about our review criteria in Reviewing affiliated packages. For each of the review categories below we have listed the score and have included some comments when the score is not green.

Functionality/Scope General package
No further comments
Integration with Astropy ecosystem Green
This was astropy.io.misc.asdf, so naturally it is already very well-integrated.
Documentation Green
Documentation is there but now that this is its own package, it could be expanded but nothing fundamental is "missing," so I gave it a green instead of orange. I opened follow up issues at asdf-astropy#72, asdf-astropy#73, and asdf-astropy#74 but none of them are blockers.
Testing Green
Uses GitHub Actions and tox, with extensive workflows and test matrix set up. Coverage is at 93%. The test suite appears to be in very good shape!
Development status Green
Last release was as recent as last month. I see a healthy amount of commit activities. The issues I opened seem to have short response time. Given that DKIST, JWST, and possibly Roman are investing heavily into ASDF support, I am not worried about this package getting unmaintained in the near future.
Python 3 compatibility Green
Test suite covers Python 3.8-3.10. I have inquired about Python 3.6 and 3.7 support at asdf-astropy#75 and asdf-astropy#76, but they are not blockers.

Summary/Decision: Everything looks great, and we're happy to confirm that this package will be accepted as an affiliated a coordinated package after a 2-week comment period (ends on 2022-06-02) for a chance for the Astropy community to speak up! 🏆

If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the affiliated package editors listed on the Astropy team page, and we will do a new review.

pending comment period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants