Repository navigation
Add general maintainers role for astropy core package - #475
Merged
Merged
Conversation
pllim
reviewed
Feb 10, 2022
Member
|
LGTM |
eteq
approved these changes
Feb 24, 2022
eteq
left a comment
eteq
left a comment
Member
There was a problem hiding this comment.
Happy with this broadly, but I've suggested what I can remember as part of the discussion in the telecon of the boundary between the generalist and the devops role.
Co-authored-by: Erik Tollerud <[email protected]>
Member
Author
|
I've added "triaging" to this new role and, for consistency, also to the existing sub-package maintainers roles. I think it's unfair to leave that all to DevOps and there might be cases that that maintainers can actually triage better. a\Adding labels is also non-destructive, so if anyone adds a wrong one, somebody else can fix it any time. The problem is that we don't have enough people helping out (when @pllim is on vacation it's just not happening), not that too many people contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been discussed in the dev telecon 2022-02-03 and there was general agreement to add such a role. This PR is a draft of that role description; unfortunately I don't remember exactly how we described this role in the telecon, so this is based on my notes, my recollection and the discussion in astropy/astropy-project#136
@bsipocz You had a very good description of this role in the last dev telecon, but I was not fast enough to write that down. Could you please have a look at this and comment or suggest changes to include what you said?
x-ref: astropy/astropy-project#136