Repository navigation
Change link colour in unified theme - #58
Merged
Merged
Conversation
astrofrog
approved these changes
May 12, 2026
astrofrog
left a comment
astrofrog
left a comment
Member
There was a problem hiding this comment.
Looks good to me, and more standard so hopefully less controversial 👍
Cadair
commented
May 12, 2026
| .navbar-nav .concertina-toggle:hover, | ||
| .bd-header .dropdown-item:hover, | ||
| .bd-header .concertina-toggle:hover { | ||
| color: var(--sst-accent-color-muted); /* Override the header link color back to sunpy */ |
Member
Author
There was a problem hiding this comment.
I've made the links in the header bright as the default pst colours do not make the required contrast against the lighter background colour of the nav bar.
1 task
Member
Author
|
@taldcroft would you like to review this? |
taldcroft
approved these changes
May 12, 2026
Member
There was a problem hiding this comment.
Assuming that the theme colors apply to the preview artifacts, then looks good. Thanks!
Unrelated, but the section title "New astropy theme colors" should probably be changed to "Astropy theme colors" since they are now (or will soon be) not "new". But that is out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview here: https://output.circle-artifacts.com/output/job/d2a87afc-efd3-473b-a8a2-d448fe79cc90/artifacts/0/html/index.html while we wait for #59