Repository navigation
Repo Cleanup - #47
Repo Cleanup#47
Conversation
7f6906a to
00091a1
Compare
|
There's a test build of astroquery here: https://astroquery--3505.org.readthedocs.build/en/3505/ with these changes just to make sure nothing untoward happened. |
|
I added the label and the repo secret (and the redirect job), but I don't think most of it will have any effects until those configs lands on |
|
Just out of curiosity could we actually use RTD for the preview instead of CircleCI? |
|
We should probably setup RTD as well to test the RTD specific stuff, but the reason I went with circle is so I can build a version with both themes in #48 |
|
What did I do and why? 
|
|
It's ok it didn't actually upload. I've not actually used this trusted publishing thing before |
|
But shouldn't it be just triggered when ready? I mean that messaging in the middle of a non-passing PR is disturbing to say the least. |
|
Yeah it's weird I'll have a play tomorrow |
This brings it closer to astropy#48 as well
|
@bsipocz I modified the release workflow to only hit the upload action on tags, not on PRs with the wheel label. |
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Looks good overall! Just a couple minor comments, but not critical, so approving from my side.
| <span class="sd-sphinx-override sd-badge pst-badge pst-target">target</span> | ||
| </p> | ||
|
|
||
| This theme uses shadows to convey depth in the light theme mode and opacity in the dark one. |
There was a problem hiding this comment.
Technically is this specific to the pydata theme?
There was a problem hiding this comment.
Well the test code is it uses their css variables.
|
@astrofrog @bsipocz can we merge this? 👼 |
|
I didn't see any objections from @bsipocz before and this is mainly infrastructural anyway, so let's go ahead so it doesn't hold back your other work. |
and thanks for fixing circleci, I forgot to come back to it yesterday. |
closes #36
closes #44
Also generally updates things before I add the new theme.
Can someone with the requisite permissions please add: