Repository navigation
DEP: drop dangling runtime dependency on setuptools - #36
Closed
neutrinoceros wants to merge 1 commit into
Closed
neutrinoceros wants to merge 1 commit into
neutrinoceros wants to merge 1 commit into
Conversation
neutrinoceros
marked this pull request as ready for review
December 5, 2024 14:22
neutrinoceros
force-pushed
the
dep/drop_unused_runtime_setuptools
branch
from
December 5, 2024 14:24
ac3173b to
2dc3c9b
Compare
neutrinoceros
commented
Dec 5, 2024
Comment on lines
-24
to
-25
| install_requires = | ||
| setuptools>=30.3.0 |
Author
There was a problem hiding this comment.
to be clear; only this part is problematic, setup_requires is fine in itself, but it's still redundant with pyproject.toml and should not be needed at all with python_requires = >=3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running the following command from
astropy/:I find that this package doesn't actually require setuptools at runtime, so I assume it was listed by mistake when it should only have been a build-time requirement.