Skip to content

Phase 3 Funding | Starkman & Foreman-Mackey | Units - #269

Merged
eteq merged 3 commits into
astropy:mainfrom
nstarman:units_proposal
Nov 7, 2022
Merged

eteq merged 3 commits into
astropy:mainfrom
nstarman:units_proposal

Conversation

@nstarman

@nstarman nstarman commented Jul 8, 2022 •

Copy link
Copy Markdown
Member

For your consideration.

Signed-off-by: nstarman [email protected]

@eteq

eteq commented Jul 8, 2022

Copy link
Copy Markdown
Member

I for one love this project! One question for @nstarman and/or @dfm : I note dask has not come up here other than as one of many examples. I just submitted the much-less-fleshed out #283 (as an open call) - do you think that's actively in conflict with that? If so I would be fine deferring #283 to the future so you have some time to try this.

@nstarman

nstarman commented Jul 8, 2022 •

Copy link
Copy Markdown
Member Author

@eteq, glad to hear it!

We are not planning to directly implement Dask support in this proposed project, but the framework we will describe in the report is compatible with Dask and many other duck arrays. When the report is submitted and if the community likes it and an APE is made and implemented then Quantity + Dask, Sparse COO, xarray, pandas are all things we can implement -- Some, like Dask, more easily than pandas. I'm not sure what the funding timeline looks like, but perhaps #283 could be to fund someone to finish the reference implementation from this proposal (when it's submitted), focusing on Dask. We believe we've solved how Quantity can work with any duck array and still have the current API (including view) when working with numpy arrays.

@eteq

eteq commented Jul 25, 2022

Copy link
Copy Markdown
Member

Because the estimated total of all the proposals is a bit higher than the amount available for allocation, we suggest that you (@nstarman) provide a budget range - i.e., a "minimum for this project to be viable" and "maximum you could use effectively for this project".

Signed-off-by: nstarman <[email protected]>
@kelle
kelle marked this pull request as ready for review August 22, 2022 15:29
@kelle

kelle commented Aug 22, 2022

Copy link
Copy Markdown
Member

Please react to this comment to vote on this proposal (👍, 👎, or no reaction for +0).

@pllim

pllim commented Aug 22, 2022

Copy link
Copy Markdown
Member

How does this overlap with the dicussions at astropy/astropy#13460 and https://discuss.scientific-python.org/t/unitsxd-units-across-domains-coordination/349 ?

@nstarman

nstarman commented Sep 3, 2022 •

Copy link
Copy Markdown
Member Author

Apologies, I missed this notification. I think this is very relevant. https://discuss.scientific-python.org/t/unitsxd-units-across-domains-coordination/349 links two related, but separate discussions: how units work (multiplication, dimensions, etc), and how the associated unit-less arrays are stored. Both are necessary, especially if we want a unified approach. This proposal is to focus on the latter question --basically Quantity -- and map out how Astropy can both support the growing community of array libraries and also remain backward compatible during this transition.

@jdswinbank

Copy link
Copy Markdown
Contributor

Congratulations! The community has expressed support for this FR, and the Finance Committee has determined it can be funded. This FR has been approved for $8,400, to be funded from the NASA grant.

@eteq is the Finance Committee member who will be supporting this project. They will update this PR with the amount and then merge it, as well as being in contact with you to set up any necessary agreements and relevant Open Collective financial arrangements. They will also open a new issue where progress on this project can be discussed.

@nstarman

nstarman commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

Thanks @jdswinbank for this update. I'm excited to receive this funding and grateful for Astropy's investment in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants