This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Repository navigation
Fix build_ext in case where Cython is not available but required and installed via setup_requires - #452
Merged
Conversation
…installed via setup_requires
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 77.38% 77.56% +0.17%
==========================================
Files 11 11
Lines 1026 1034 +8
==========================================
+ Hits 794 802 +8
Misses 232 232
Continue to review full report at Codecov.
|
bsipocz
approved these changes
Feb 7, 2019
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
I trust you have tested this with your PR for astropy core and it works with it as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comment in the code here - basically if cython was needed and specified in setup_requires, things didn't work correctly because we imported setuptools' build_ext command too soon.