Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Add --no-git argument to setup.py, recognized by ah_bootstrap - #27

Merged
embray merged 1 commit into
astropy:masterfrom
embray:no-git
Jun 2, 2014
Merged

embray merged 1 commit into
astropy:masterfrom
embray:no-git

Conversation

@embray

@embray embray commented May 30, 2014

Copy link
Copy Markdown
Member

This will prevent, for example, auto-update of the astropy_helpers submodule.

APE4 has also been updated to document this option: embray/astropy-APEs@6174460

… will prevent, for example, auto-update of the astropy_helpers submodule.
embray added a commit to embray/astropy-APEs that referenced this pull request May 30, 2014
@eteq

eteq commented May 30, 2014

Copy link
Copy Markdown
Member

@embray - this PR itself looks good, but one thing that's confusing: none of this appears in the "python setup.py --help" documentation, which is where users are going to look for this. So perhaps ah_bootstrap.py should watch for --help, and display its own help if that's given?

@embray

embray commented May 30, 2014

Copy link
Copy Markdown
Member Author

I'll have to think about that. As you've noticed it just nabs those options off of sys.argv. It has no interaction with distutils itself regarding command-line options. I think maybe it could insert them into distutils' argument parsing at an early stage...

@astrofrog

Copy link
Copy Markdown
Member

👍 to --no-git. I would be in favor of merging this and opening a separate issue for the --help issue.

@astrofrog

Copy link
Copy Markdown
Member

@embray - shall we merge this now and worry about the help option later, or do you think that should be resolved now too?

@embray

embray commented Jun 2, 2014

Copy link
Copy Markdown
Member Author

Submitted a new issue. Incidentally, I think I need to updated APE-4 regarding how issues for astropy-helpers are handled. Previously we had agreed not to use a separate issue tracker, and yet here we are doing that. I, ultimately, find this preferable actually. But as a compromise we I think we should say that users should submit issues to Astropy's main issue tracker. If an issue turns out to be something in astropy-helpers then one of use can create a separate issue here to track it.

In other words, we wouldn't advertise this issue tracker to users. (Though if developers and more savvy users find this one and report astropy-helpers issues directly to it there's no harm in that either).

embray added a commit that referenced this pull request Jun 2, 2014
Add --no-git argument to setup.py, recognized by ah_bootstrap
@embray
embray merged commit 2b654a0 into astropy:master Jun 2, 2014
@embray
embray deleted the no-git branch June 2, 2014 16:42
@eteq eteq mentioned this pull request Jul 22, 2014
@astrofrog astrofrog modified the milestone: 0.4.0 Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants