This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Adding collections.Mapping to the local python3 inventory #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@bsipocz - any idea what happened here? |
Member
Author
|
@astrofrog - This is weird, the isn't any sphinx test on appveyor so this shouldn't affect anything there. |
Member
Author
|
Ohh, now I got some vague memories back. The appveyor builds are failing for a long time, but in the last helpers spring we didn't have time to fix it and forgot about it since (at least I forgot about it). |
Member
|
The AppVeyor failure is unrelated, so merging this. |
|
@astrofrog - thanks for merging this! However, I noticed the following issue with this pull request:
Would it be possible to fix this? Thanks! This is an experimental bot being written by @astrofrog - let me know if the message above is incorrect! |
astrofrog
added a commit
to astropy/sphinx-astropy
that referenced
this pull request
Jan 29, 2018
…tend_py3_inv Adding collections.Mapping to the local python3 inventory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #237 this causes a problem with the python3 sphinx builds (while it still can be imported from the old namespace).
This is also needed for astropy/astropy#4556 to pass.