Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Conversation

@eteq
Copy link
Member

@eteq eteq commented Apr 19, 2016

This is an effort to address the problem in #222 based on @astrofrog's #222 (comment) .

I'm actually having some trouble reproducing the issue locally - it may be that setuptools 21.x has fixed it? It's probably good to have this in for insurance anyway, though...

At any rate, let's see if the tests pass. If so, then I think this closes #222.

@embray
Copy link
Member

embray commented Apr 20, 2016

Weird, but okay. Anyone have any idea what's wrong with the CI?

@astrofrog
Copy link
Member

Not sure, it seems to be related to a heading underline being the wrong length, presumably because of the package name changing length?

cython_testpackage = local('/tmp/pytest-0/test_am_replacer_cython0/test_pkg')

�[1m    def test_am_replacer_cython(cython_testpackage):�[0m
�[1m        """�[0m
�[1m        Tests replacing an ".. automodapi::" for a Cython module.�[0m
�[1m        """�[0m
�[1m    �[0m
�[1m        from ..automodapi import automodapi_replace�[0m
�[1m    �[0m
�[1m        fakeapp = FakeApp()�[0m
�[1m        result = automodapi_replace(am_replacer_cython_str.format(options=''),�[0m
�[1m                                    fakeapp)�[0m
�[1m    �[0m
�[1m>       assert result == am_replacer_cython_expected�[0m
�[1m�[31mE       assert '\nThis comes...comes after\n' == '\nThis comes ...comes after\n'�[0m
�[1m�[31mE         Skipping 56 identical leading characters in diff, use -v to show�[0m
�[1m�[31mE         - -----------------�[0m
�[1m�[31mE         + ----------�[0m
�[1m�[31mE           �[0m
�[1m�[31mE           .. automodule:: apyhtest_eva.unit02�[0m
�[1m�[31mE           �[0m
�[1m�[31mE           Functions�[0m
�[1m�[31mE           ^^^^^^^^^�[0m
�[1m�[31mE           �[0m
�[1m�[31mE           .. automodsumm:: apyhtest_eva.unit02�[0m
�[1m�[31mE               :functions-only:�[0m
�[1m�[31mE               :toctree: api/�[0m
�[1m�[31mE           �[0m
�[1m�[31mE           This comes after�[0m```

@eteq
Copy link
Member Author

eteq commented Apr 20, 2016

Oops, yeah, my bad. Will fix that and then rebase

@eteq eteq force-pushed the fix-eva-problem branch from 4b84ef7 to ef224fc Compare April 20, 2016 17:08
@eteq
Copy link
Member Author

eteq commented Apr 20, 2016

(and note that this isn't getting a milestone because it's a testing-only change)

@eteq eteq added the testing label Apr 20, 2016
@eteq
Copy link
Member Author

eteq commented Apr 20, 2016

OK, this is now passing (the appveyor issue seems to be due to graphviz's web site being down...). @embray and/or @astrofrog, look good to you?

@astrofrog
Copy link
Member

👍

@eteq
Copy link
Member Author

eteq commented Apr 25, 2016

Alright - merging!

@eteq eteq merged commit 111b1e5 into astropy:master Apr 25, 2016
@eteq eteq deleted the fix-eva-problem branch April 25, 2016 14:42
@astrofrog astrofrog modified the milestone: v1.2 Jun 2, 2016
@bsipocz
Copy link
Member

bsipocz commented Jun 10, 2016

@astrofrog - I've noticed that v1.0.7 is failing. Could you please backport this one, it takes care some of the failures. (Locally only one remained when I've cherry-picked these commits).

@bsipocz
Copy link
Member

bsipocz commented Jun 10, 2016

Ok, so the branch on top of v.1.0.7 with the cherry-picked commits from various PR is this: https://travis-ci.org/bsipocz/astropy-helpers/builds/136710524

astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure out why the travis tests are failing on the "eva" version name

4 participants