Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Conversation

@eteq
Copy link
Member

@eteq eteq commented Apr 19, 2016

This PR fixes the remaining warning in sphinx 1.4 (see #227). It's a terribly hacky fix, but it's the only way I see to supress the warning.

Hopefully sphinx-doc/sphinx#2451 will eventually get addressed, and then we can instead suppress the warning in a more reasonable way.

cc @bsipocz

eteq added 6 commits April 19, 2016 18:10
this is terribly hacky, but it's the only way I see to supress the warning.
The warning is actually a red herring, because we *mean* to override the
directive in question...

closes astropy#227
io doesn't work on py 2.x b/c it expects unicode
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2016

@eteq - There is some progress on sphinx-doc/sphinx#2451, but it doesn't seem working for me. Maybe link that sphinx issue before the try/finally as a reminder.

So 👍 merging this now, and once a working patch is out in an upstream release, we can remove this hack.

@eteq
Copy link
Member Author

eteq commented Apr 20, 2016

Sounds good - I will add a comment pointing to that issue and then merge this. Thanks @bsipocz !

@eteq
Copy link
Member Author

eteq commented Apr 20, 2016

Alright, merging this. Will create a new issue to replace this once sphinx 1.4.2 is out.

@eteq eteq merged commit 5d43914 into astropy:master Apr 20, 2016
@eteq eteq deleted the fix-227 branch April 20, 2016 16:50
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2016

Just to confirm it here sphinx-doc/sphinx#2451 works as expected.
(I just messed up the pulling of the latest dev version on top of my locally hacked one in the afternoon.)

@astrofrog astrofrog modified the milestone: v1.2 Jun 2, 2016
@bsipocz
Copy link
Member

bsipocz commented Jun 10, 2016

@astrofrog - This is another one for backportation (however at some point should be removed, but sphinx 1.4.2 is not yet ready on conda just via pip).

astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants