-
-
Notifications
You must be signed in to change notification settings - Fork 44
Work around sphinx 1.4 warning #229
Conversation
this is terribly hacky, but it's the only way I see to supress the warning. The warning is actually a red herring, because we *mean* to override the directive in question... closes astropy#227
io doesn't work on py 2.x b/c it expects unicode
|
@eteq - So 👍 merging this now, and once a working patch is out in an upstream release, we can remove this hack. |
|
Sounds good - I will add a comment pointing to that issue and then merge this. Thanks @bsipocz ! |
|
Alright, merging this. Will create a new issue to replace this once sphinx 1.4.2 is out. |
|
Just to confirm it here sphinx-doc/sphinx#2451 works as expected. |
|
@astrofrog - This is another one for backportation (however at some point should be removed, but sphinx 1.4.2 is not yet ready on conda just via pip). |
Work around sphinx 1.4 warning
Work around sphinx 1.4 warning
This PR fixes the remaining warning in sphinx 1.4 (see #227). It's a terribly hacky fix, but it's the only way I see to supress the warning.
Hopefully sphinx-doc/sphinx#2451 will eventually get addressed, and then we can instead suppress the warning in a more reasonable way.
cc @bsipocz