Cleanup PR #226
Cleanup PR #226
Conversation
bsipocz
force-pushed
the
pep8_and_container_travis
branch
from
6e83fae to
5c1e342
Compare
astropy_helpers/setup_helpers.py
Outdated
| except ImportError: | ||
| raise DistutilsModuleError( | ||
| 'cannot find hook {0}: {1}'.format(hook, err)) | ||
| 'cannot find hook {0}: {1}'.format(hook, err)) |
There was a problem hiding this comment.
This looks like a bug. My guess is pylint or whatever warned that exc is not used, but actually it is on this line but the variable was accidentally renamed err here. Should change back to as exc and change err to exc here.
bsipocz
force-pushed
the
pep8_and_container_travis
branch
from
c77c489 to
8575831
Compare
|
Hmm, it's a fair question what the oldest version of sphinx we want to support is. I think older sphinxes are less of a priority because it's sort of a "dev-oriented" thing to need to build the sphinx docs. @astrofrog or anyone else have any opinions? Note, though, @bsipocz, that I think it makes sense to update the |
bsipocz
force-pushed
the
pep8_and_container_travis
branch
from
8575831 to
964b372
Compare
|
@eteq - changed |
|
Hmm, yeah, now that you ask, I suppose upgrading the required sphinx is something we wouldn't want in a bugfix. So I'd say 1.2 |
|
@bsipocz - actually, @astrofrog raised a good point that this affects the affiliated packages, so you should ask on astropy-affiliated-maintainers if anyone minds having to upgrade to 1.3 . If everyone there is OK with it I'd say it's ok to include this for helpers v1.2 |
|
That's a good point, I'll send out an e-mail. |
bsipocz
force-pushed
the
pep8_and_container_travis
branch
from
964b372 to
76d4bd8
Compare
|
@eteq - There was no reaction to the e-mail about this, so I assume everyone is OK with upgrading to sphinx >=1.3. |
|
@bsipocz - can you rebase? |
…patch got merged upstream since Sphinx version 1.3
bsipocz
force-pushed
the
pep8_and_container_travis
branch
from
76d4bd8 to
ca024ed
Compare
|
@astrofrog - Done |
|
I think AppVeyor is broken for unrelated reasons, so I'll go ahead and merge and debug that in another issue. |
|
I was just about to open an issue about the appveyor failures, as said on one of the other PR it's around for a long time. |
…container_travis Cleanup PR
…container_travis Cleanup PR
…container_travis Cleanup PR
4 participants
This PR does a few low prio cleanup tasks:
I think the only controversial point is the viewcode removal. The patch got included 1.5 years ago into 1.3b1. I think it's a long enough time, and we can remove our local version.
Note that this fails, but when built on top of #225 the tests pass (https://travis-ci.org/bsipocz/astropy-helpers/builds/123386933).