-
-
Notifications
You must be signed in to change notification settings - Fork 44
Python3 links not working #214
Conversation
|
@mhvk - |
|
Replacing the local file with |
|
Since |
|
That sounds like a plan that also saves me the pain of figuring out how I digged those links in the local file out of the binary inventory. |
1422406 to
8ff08ec
Compare
|
@bsipocz - I turned this into a PR, but am not sure this is the right way to go about it; if not, please feel free to make an alternative PR. |
|
@mhvk - Can you confirm that this works with python2? I fear that removing the local hack inventory will brake those links that are listed in it at the moment. |
|
@bsipocz - sadly, it doesn't seem this simple solution suffices. Building astropy documentation on python2, I seem to get only warnings for a missing reference to |
|
I don't think preserving inter-sphinx references to all Python builtins is deeply important in all cases. I like this solution, and for any cases where it doesn't work add nitpick exceptions. |
|
See #216 for a solution that works for both py2 ad py3. Since most affiliates uses python2 I think that we should keep the py2 compatibility of the helpers for a little longer (even if switching to py3 sphinx builds in astropy master). |
|
This can be closed as the superseding #216 is merged. |
|
Yes, you're right. Closing... |
In astropy/astropy#4465, I found that using
python3 setup.py build_sphinx, links to python3SyntaxWarningandRuntimeWarningwere not working. I can solve this locally by replacing the local storage file for python3 listed in https://github.com/astropy/astropy-helpers/blob/master/astropy_helpers/sphinx/conf.py#L46 withNone. Does that make sense?