Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Conversation

@eteq
Copy link
Member

@eteq eteq commented Apr 29, 2015

Someone at the Lorentz center python meeting (I think @kbarbary or maybe @cmccully or perhaps @Cadair ?) mentioned that they found the command build_sphinx to be confusing. This basically just adds an alias to build_shinx command called build_docs .

I have some misgivings about this because it's two commands that do the same thing, but I think build_docs is much more natural for someone who might not understand what "sphinx" is, so I mildly think it's worth it.

cc @embray @astrofrog

@Cadair
Copy link
Member

Cadair commented Apr 29, 2015

I think this was me... It has always bugged me a little bit.

@embray
Copy link
Member

embray commented May 4, 2015

I'm okay with it.

@embray embray modified the milestones: v1.1, v1.0.3 May 4, 2015
@embray
Copy link
Member

embray commented May 4, 2015

No reason this can't go in a patch release. Just add a changelog entry for v1.0.3 please.

@embray
Copy link
Member

embray commented May 4, 2015

A concurrent update in the Astropy docs is a good idea too. I'd be in favor of build_sphinx -> build_docs all around.

@astrofrog
Copy link
Member

+1 from me too (but let's keep build_sphinx for a while to avoid breaking all the CI)

embray added a commit that referenced this pull request Jul 7, 2015
add build_docs command/alias
@embray embray merged commit 000b444 into astropy:master Jul 7, 2015
embray added a commit that referenced this pull request Jul 7, 2015
embray added a commit that referenced this pull request Jul 7, 2015
add build_docs command/alias
embray added a commit that referenced this pull request Jul 7, 2015
Conflicts:
	CHANGES.rst
embray added a commit to embray/astropy that referenced this pull request Jul 7, 2015
…uild_sphinx in the documentation to the less cryptic-looking build_docs
@eteq eteq deleted the add-docs-alias branch July 14, 2015 22:17
dhomeier pushed a commit to dhomeier/astropy that referenced this pull request Aug 11, 2015
…uild_sphinx in the documentation to the less cryptic-looking build_docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants