Reorganize setup_helpers a bit #110
Conversation
|
Mysterious unrelated failures that seem to have something to do with the test of |
|
I will rebase this on #111 again--hopefully then the tests will pass. |
|
There seems to be some network issue--either on the Ubuntu side or on the Travis side--preventing Ubuntu packages from being installed, hence causing the tests to error. Hopefully this will resolve itself soon... |
|
(it happened in astropy core and other packages too) |
|
Looks like it is indeed fixed. |
Most of the code related to implementing individual distutils commands has been moved into an astropy_helpers.commands/ subpackage, with a module devoted to each command. Some of these modules are very short and seem a bit silly, but this organization is simply to match the organization of distutils and setuptools. It also makes it easy to find where a given command is implemented. Also moved most of the functions related to introspecting distutils into a new distutils_helpers module.
|
Rebased... |
|
Hooray. |
|
@embray - just for info, this breaks the setup in the astropy core package. Is that intentional or should we try and make sure the changes are backward-compatible? |
|
In particular, it looks like |
|
Just to claify, I ran into this when trying to get astropy/astropy#3166 to work with your generalized hooks, but I think the changes here is what broke things. |
|
Oh, I didn't know. I took out Hmm, I feel like maybe that should just go into |
…ed since it is not used within astropy_helpers, but it is being used externally. However, tehre were actually two copies of this function in astropy_helpers, somehow. One in setup_helpers and one in utils. I have added it back to utils but also included it in setup_helpers via import.
… setup_helpers should still work, and added a previously overlooked changelog entry for #110.
2 participants
Broke apart and reorganized much of
astropy_helpers.setup_helpers.Most of the code related to implementing individual distutils commands
has been moved into an astropy_helpers.commands/ subpackage, with a
module devoted to each command. Some of these modules are very short
and seem a bit silly, but this organization is simply to match the
organization of distutils and setuptools. It also makes it easy to find
where a given command is implemented.
Also moved most of the functions related to introspecting distutils into
a new distutils_helpers module.
This was part of working on support for custom pre-/post-command hooks, and while it is not required for that work I felt like setup_helpers was getting a bit unwieldy and figured I should do something about that before adding more to it.