This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 11, 2024. It is now read-only.
Appveyor picks up ci-helpers test #265
Description
As @saimn points out in #261, appveyor tries to run the ci-helpers test, too rather than staying within the astropy-helpers subdir. This behaviour is new and started about a month ago. While the workaround in 909b75b works, it would be great to see what caused the changes.
Here are two runs of the same commit:
Activity
bsipocz commentedon Nov 23, 2016
OK, the difference is that the old build used pytest v2.9.2 while the new failing is running v3.x
bsipocz commentedon Nov 23, 2016
OK, sorry for the noise, this was actually a ci-helpers issue with pytest 3.x, that @astrofrog fixed today. However I still think that the ci-helpers test file shouldn't be picked up here.
saimn commentedon Nov 24, 2016
@bsipocz - Note that for Travis the test command was already running tests only for the
astropy_helpersdirectory: https://github.com/astropy/astropy-helpers/blob/master/.travis.yml#L66astrofrog commentedon Nov 24, 2016
Fundamentally, this is just because the test command is
py.testrather thanpy.test astropy_helpers. We should probably change it to the latter. The issue I fixed with ci-helpers was actually useful to identify packages that are running the ci-helpers tests by mistake ;)bsipocz commentedon Nov 24, 2016
@saimn - Fair enough. That case it was probably only a bug in pytest 2.9.2 to not pick it up.