Skip to content

Add fits benchmarks - #80

Merged
astrofrog merged 2 commits into
astropy:masterfrom
saimn:fits
Mar 25, 2019
Merged

Add fits benchmarks#80
astrofrog merged 2 commits into
astropy:masterfrom
saimn:fits

Conversation

@saimn

@saimn saimn commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

Closes #76, and also ref astropy/astropy#8502

I ran this locally to compare astropy/astropy#8502 with v3.0.2 (so the comparison also includes changes from astropy/astropy#8428, it is just to check that it is working correclty):

(py37) ❯ asv compare 275807902 0608e7a57

All benchmarks:

       before           after         ratio
     [27580790]       [0608e7a5]
          728±1ms        741±0.3ms     1.02  io_fits.FITSBinTableHDU.time_from_columns_bytes
         33.2±1ms         21.1±0ms    ~0.63  io_fits.FITSHDUList.time_getheader
-         1.59±0s        157±0.1ms     0.10  io_fits.FITSHDUList.time_getheader_ext50
-         3.15±0s        256±0.6ms     0.08  io_fits.FITSHDUList.time_len
-      21.6±0.2ms      18.4±0.04ms     0.85  io_fits.FITSHeader.time_fromstring
      7.10±0.03μs      7.12±0.03μs     1.00  io_fits.FITSHeader.time_get_float
      7.70±0.05μs      7.68±0.04μs     1.00  io_fits.FITSHeader.time_get_hierarch
      7.06±0.02μs      7.13±0.04μs     1.01  io_fits.FITSHeader.time_get_int
      7.10±0.02μs      7.09±0.02μs     1.00  io_fits.FITSHeader.time_get_str
      2.46±0.06ms      2.36±0.01ms     0.96  io_fits.FITSHeader.time_tostring
           failed           failed      n/a  io_fits.FITSHighLevelTableBenchmarks.time_read_nommap
         200±20ms         191±10ms     0.96  io_fits.FITSHighLevelTableBenchmarks.time_write

@saimn saimn mentioned this pull request Mar 25, 2019
Merged
astrofrog
astrofrog approved these changes Mar 25, 2019
View reviewed changes

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@astrofrog
astrofrog merged commit 7cc91a3 into astropy:master Mar 25, 2019
@saimn
saimn deleted the fits branch March 25, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saimn @astrofrog