Skip to content

APE 24: Astropy Affiliated Packages with pyOpenSci (now APE 22) - #87

Merged
eteq merged 22 commits into
astropy:mainfrom
pllim:ape-24-pyopensci-affil
Jan 29, 2024
Merged

eteq merged 22 commits into
astropy:mainfrom
pllim:ape-24-pyopensci-affil

Conversation

@pllim

@pllim pllim commented Jul 16, 2023 •

Copy link
Copy Markdown
Member

Initial authors: @pllim @lwasser @WilliamJamieson @dhomeier

TODO

  • Start a draft APE during Scipy 2023.
  • Finish filling in the text.
  • Have co-authors proof-read and address feedback.
    • ✔️ Leah
    • ✔️ Derek
    • ✔️ William
    • ✔️ Moritz
  • Open up to general comment period and address feedback. Done on 2023-10-23
  • Address feedback from general comment period.
  • Wait for CoCo decision. 2023-12-18: 2 abstained, 2 approved, 1 absent
  • CoCo to update PR with decision and merge.
  • ???
  • Profit!!!

Co-authored-by: Leah Wasser <[email protected]>
@pllim
pllim requested a review from dhomeier July 28, 2023 03:11
@pllim

This comment was marked as outdated.

Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
Comment thread APE24.rst Resolved
@lwasser

This comment was marked as resolved.

@lwasser

This comment was marked as resolved.

@eteq

eteq commented Jan 29, 2024

Copy link
Copy Markdown
Member

Alright, I'm happy with this, as is the rest of the coco. Merging!

@eteq
eteq merged commit e42d55b into astropy:main Jan 29, 2024
@eteq

eteq commented Jan 29, 2024

Copy link
Copy Markdown
Member

Oops, I was supposed to do the decision rationale, etc in this PR but I'll just do it directly in main instead. My bad.

@pllim
pllim deleted the ape-24-pyopensci-affil branch January 29, 2024 19:03
@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Thanks, all!

eteq added a commit that referenced this pull request Jan 29, 2024
@eteq

eteq commented Jan 29, 2024

Copy link
Copy Markdown
Member

Not also this was renumbered to APE22 in 6964140

@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Wait... why is the APE number changed?

@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

APE 22 is already claimed but just not merged:

Any chance you can change this back to original APE 24 to avoid confusion?

@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

Also there is a typo in the rationale: commitee -> committee

@eteq

eteq commented Jan 29, 2024

Copy link
Copy Markdown
Member

@lwasser - I think I found the right ORCiD for you in https://doi.org/10.5281/zenodo.10581891, but let me know if any of that is wrong and I can fix the metadata!

@eteq

eteq commented Jan 29, 2024

Copy link
Copy Markdown
Member

Any chance you can change this back to original APE 24 to avoid confusion?

The procedure in the README covers this @pllim - the numbering is in merging order. the numbering prior to merging is to be thought of as preliminary.

(The backstory is that we were struggling with deciding what to do here, and then we wrote it into the instructions and no one seemed to mind... So if we want to change that it's just a matter of changing the README instructions. I don't have a terribly strong opinion other than "we should make sure the instructions are explicit about it and follow whatever they say at any given time")

@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member Author

🤪

@pllim pllim mentioned this pull request Jan 29, 2024
@dhomeier

Copy link
Copy Markdown
Contributor

I suppose the final renaming is only done right in the merge commit then – any special tricks how to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

9 participants