Skip to content

Update APE10 to have higher minimum python 3 versions - #25

Merged
eteq merged 3 commits into
astropy:masterfrom
mhvk:patch-2
May 31, 2017
Merged

eteq merged 3 commits into
astropy:masterfrom
mhvk:patch-2

Conversation

@mhvk

@mhvk mhvk commented May 3, 2017

Copy link
Copy Markdown
Contributor

Following discussion in astropy/astropy#6000: change the minimum version for python 3 such that the minimum python version will be supported for (most of) the lifetime of any astropy release.

Following discussion in astropy/astropy#6000: change the minimum version for python 3 such that the minimum python version will be supported for (most of) the lifetime of any astropy release.
@astrofrog

Copy link
Copy Markdown
Member

I'm not sure if we ever made a decision on updating APEs, but I feel like this is a valid case

Comment thread APE10.rst
issues). Because of this apparent support by the community and agreement from
the coordination committee with the goals of this APE, it was accepted Aug 22,
2016.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this explanation is very clear.

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@mhvk

mhvk commented May 8, 2017

Copy link
Copy Markdown
Contributor Author

@astrofrog, @eteq - shall we merge this change in minimum python version addendum? I made the PR to implement removing python3.3 tests in master -- astropy/astropy#6021

@MSeifert04

MSeifert04 commented May 8, 2017 •

Copy link
Copy Markdown

Just a minor point: astropy 3.0 isn't a LTS and python 3.4 wouldn't reach end of life till 2019 (expected: 2019-03-16). So following the logic in the APE, including the new update, python 3.4 should be supported until astropy 3.2 or 3.3.

That doesn't mean I'm opposed to dropping python 3.4 support earlier - I'm definetly for it, there are a lot of amazing and handy new features in 3.5 and 3.6! It's just that nothing in the APE (including update) justifies that.

@bsipocz

bsipocz commented May 9, 2017

Copy link
Copy Markdown
Member

As v3.0 is already a python3 only version, we will have tons of code removal for it. If we refactor anyway, being able to use py3.5+ features would be really nice, and py3.7 will come out just before v3.1.

Can we do a new survey anytime soon to estimate how large percentage of our users use py3.4 as their main version?

@kelle

kelle commented May 9, 2017

Copy link
Copy Markdown
Member

I'd be happy to put up a poll on the FB group. I think there's enough people there to give a robust sampling. I'll discuss with folks today F2F at PyAstro17.

@astrofrog

Copy link
Copy Markdown
Member

We can do a poll on twitter too with the following options:

Python 2.7
Python 3.0-3.2
Python 3.3-3.4
Python 3.5+

(since limited to 4 options)

@saimn

saimn commented May 9, 2017

Copy link
Copy Markdown

As long as Python 2 is supported there is no real gain to drop support for Python 3.3 (except saving CI time), as it is not possible to use the new Python 3 features anyway. So for Astropy 2.0, even if there is no official support for Python 3.3, it should still be usable.

It will be more interesting for the following versions, when Python 2 is no more supported ! Dropping Python 3.4 for Astropy v3.0 seems reasonable, since this version is probably not widely used. I use py3.4 for our unit tests with the current Debian stable, but a new version of Debian should come in a few months with Python 3.5. And the latest Ubuntu LTS also comes with Python 3.5.

@bsipocz

bsipocz commented May 9, 2017

Copy link
Copy Markdown
Member

@saimn - The main argument for dropping py3.3 for v2.0 is that it will become unsupported during the lifetime of the release and thus we better don't say that we support it (while it may of course still work).

@saimn

saimn commented May 9, 2017

Copy link
Copy Markdown

@bsipocz - Sure, and that's a good motivation.

@MSeifert04

MSeifert04 commented May 9, 2017 •

Copy link
Copy Markdown

As long as Python 2 is supported there is no real gain to drop support for Python 3.3 (except saving CI time), as it is not possible to use the new Python 3 features anyway.

That's not the whole motivation.

Python 2.7 still receives bugfixes, while 3.3 does not (except for security related ones, ordinary bugfixes have been stopped since March 9th, 2014 - more than 3 years ago!). So by dropping 3.3 we can remove workarounds for bugs fixed in 2.7 and 3.4+ but not in 3.3.

@mhvk

mhvk commented May 9, 2017

Copy link
Copy Markdown
Contributor Author

A poll sounds like a good idea: always good to have some real data!

@eteq eteq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except "date-last-revised" needs to be updated.

@eteq

eteq commented May 12, 2017

Copy link
Copy Markdown
Member

Realized it was easier to just implement my comment, so all is good!

@saimn

saimn commented May 12, 2017

Copy link
Copy Markdown

@eteq

eteq commented May 12, 2017 •

Copy link
Copy Markdown
Member

@saimn - just to be clear: are you happy with this given #25 (comment) / #25 (comment) ?

@saimn

saimn commented May 12, 2017

Copy link
Copy Markdown

@eteq - Yes that's fine for me (sorry if my initial comment was not clear)

@eteq

eteq commented May 13, 2017

Copy link
Copy Markdown
Member

OK, great. @astrofrog, if this looks good to you, I think this is set to go.

Comment thread APE10.rst Outdated
Updates after acceptance of the APE
-----------------------------------
In further discussions (https://github.com/astropy/astropy/issues/6000), it was
noted that one should not aim to support versions of python that will reach end

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instances of python should be capitalized.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mhvk

mhvk commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

It seems all of you approved the changes to APE10 - so, ready to merge!?

@eteq

eteq commented May 31, 2017

Copy link
Copy Markdown
Member

All good. Merging, and thanks @mhvk!

@eteq
eteq merged commit 5fe1422 into astropy:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants