Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
0f08ec2
APE26 draft
jeffjennings Nov 4, 2024
47397d0
APE26: rst formatting
jeffjennings Nov 4, 2024
e851dca
APE26: further rst format
jeffjennings Nov 4, 2024
6d04c1e
APE26: typo
jeffjennings Nov 4, 2024
5fa8038
APE26: typo2
jeffjennings Nov 4, 2024
bfb2732
APE26: typo3
jeffjennings Nov 4, 2024
7799687
APE26: .rst formatting
jeffjennings Nov 4, 2024
266a2cc
APE26: typo4
jeffjennings Nov 4, 2024
46f503e
APE26: add PR titles
jeffjennings Nov 4, 2024
c87fcc7
Address comments by Eero
mhvk Nov 26, 2024
a50960c
Use Base* names since that is more common in astropy
mhvk Nov 26, 2024
9e33a95
Merge pull request #1 from mhvk/name-changes
jeffjennings Jan 29, 2025
0be3ee0
Replace 'LegacyCoordinateFrame' with 'BaseCoordinateFrame'
jeffjennings Jan 29, 2025
f9ec3a6
Replace 'LegacyCoordinateFrame' with 'BaseCoordinateFrame'
jeffjennings Jan 29, 2025
07f7da2
Add 'Coordinate' class
jeffjennings Jan 29, 2025
16a3310
indentation
jeffjennings Jan 29, 2025
64a1f2d
integrate text on APE 5 and departures from it
jeffjennings Feb 10, 2025
46a6d82
Merge pull request #2 from jeffjennings/text_edits_ape5
jeffjennings Feb 10, 2025
cea5bc7
docs: add verbiage about Coordinate
nstarman Apr 24, 2025
7ffc3a5
docs: update wording
nstarman Apr 27, 2025
c70b0fb
Merge pull request #3 from nstarman/APE26
jeffjennings Apr 28, 2025
1c3607b
format to max 70 char line length
jeffjennings Apr 28, 2025
408a937
APE26: update revision date
jeffjennings Apr 28, 2025
b73abfc
APE26: grammar
jeffjennings May 8, 2025
c45c437
APE26: grammar
jeffjennings May 8, 2025
3294d49
add note about APE26 in APE5
jeffjennings May 8, 2025
d801d8d
APE26: move link up
jeffjennings May 8, 2025
87ef33d
APE26: grammar
jeffjennings May 8, 2025
2c7c9b1
APE26: add link
jeffjennings May 8, 2025
ed97772
APE26: add link
jeffjennings May 8, 2025
f7e56e6
APE26: text
jeffjennings May 8, 2025
68f5dd2
Update APE26.rst
jeffjennings May 8, 2025
a7c80f2
APE26: text
jeffjennings May 8, 2025
c5a51f0
APE26: text
jeffjennings May 8, 2025
78f92d5
APE26: text
jeffjennings May 8, 2025
9332ae6
APE26: update point on tests
jeffjennings May 8, 2025
cd5471b
APE26: update wording
jeffjennings May 8, 2025
062755f
APE26: update example
jeffjennings May 8, 2025
4e66710
Update APE26.rst
jeffjennings Jan 23, 2026
1ab6e5b
Update APE26.rst
jeffjennings Jan 23, 2026
0cb9eff
Update APE26.rst
jeffjennings Jan 23, 2026
1f551d4
Update APE26.rst
jeffjennings Jan 23, 2026
8f7711a
Add note on erroneous methods
jeffjennings Jan 23, 2026
ae93078
Add deprecation period note
jeffjennings Jan 23, 2026
fa2df27
Add API difference example
jeffjennings Jan 23, 2026
164e30d
add links to prototype and demo
jeffjennings Jan 23, 2026
5a14258
add example usage patterns
jeffjennings Jan 23, 2026
9fdb1b5
add note on APE5 comparison
jeffjennings Jan 23, 2026
19bfe90
add revision date and note
jeffjennings Jan 23, 2026
a6fa590
Incorporate APE editor changes
jeffjennings Jan 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add API difference example
  • Loading branch information
jeffjennings committed Jan 23, 2026
commit fa2df27a8b7001825e1d883be53146ae3ee47ec4
12 changes: 11 additions & 1 deletion APE26.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ but not identical APIs:
c1 = SkyCoord(1., 2., frame="icrs", units="deg")
c2 = ICRS(1. * u.deg, 2. * u.deg)

Consequently user confusion can arise from an operation as common as
transforming reference frames:

.. code-block:: python

c1g = c1.transform_to(Galactic()) # Works
c2g = c2.transform_to(Galactic()) # Works
c1g = c1.transform_to("galactic") # Works
c2g = c2.transform_to("galactic") # Raises ConvertError

We suggest the situation should instead be analogous to what is the
Comment thread
kbwestfall marked this conversation as resolved.
Resolved
case for units, which know how to transform from one to another, but
are not concerned with how the values are stored (that belongs to
Expand Down Expand Up @@ -120,7 +130,7 @@ worthwhile to separate coordinate data from reference frames at
the possible expense of developers having to learn this new
framework.

All the points discussed thus far – separation of concerns and
The major points discussed thus far – separation of concerns and
code duplication – concern maintainers. However user experience
is the more important consideration. In this arena too,
separating frames from data storage has its advantages. Perhaps
Expand Down