Fix memory corruption bugs in WCSLIB/wcscopy for WCS-TAB#9845
Merged
nden merged 1 commit intoastropy:masterfrom Jan 8, 2020
Merged
Fix memory corruption bugs in WCSLIB/wcscopy for WCS-TAB#9845nden merged 1 commit intoastropy:masterfrom
nden merged 1 commit intoastropy:masterfrom
Conversation
Contributor
Author
|
CC: @nden @MSeifert04 |
nden
added
Affects-dev
Contributor
|
The bug and fix were reported upstream. I will merge this patch meanwhile so we can proceed with the |
nden
approved these changes
Jan 8, 2020
Member
|
Now you can finally sleep at night, @mcara ! 😅 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements bug fixes in WCSLIB that lead to memory corruption in wcscopy when a WCS has -TAB. This should fix memory corruption issues in #9641 PR. No unit tests added in this PR but the affected code gets invoked only when -TAB is present in the WCS so it should not affect existing functionality.