Repository navigation
Fix doctest race condition - #9800
Merged
Merged
Conversation
Contributor
|
Related to #9796 ? |
Member
Author
|
@MSeifert04 - indeed, good catch! I've added a mention of that in the description so that the issue auto-closes. |
Contributor
|
@astrofrog - for this example, the output file is not checked, so it is fine if it changes underneath. Is that true for the other example as well? |
Member
Author
|
@mhvk - yes, the overwrite is safe for the other example too, the content of the files is not checked. |
mhvk
approved these changes
Dec 18, 2019
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
OK, given that both examples are safe, approving.
Contributor
|
I'll merge too since those failures are very distracting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen a failure happen in the 32-bit parallel build which is due to two doctests both needing to write to a file called
values.dat. I think until recently the tests were always run such that the one withoverwrite=Truecame second but now things have flipped so an error is happening.Ideally we should run doctests in an isolated way that prevents this from happening, but for now this is a quick fix. I'm also renaming the CircleCI build for 32-bit to mention it is also a parallel build since this is often a source of confusion.
Fixes #9796