Skip to content

TST: Ignore cache warning on Windows - #9634

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:win-cache-warn
Nov 27, 2019
Merged

TST: Ignore cache warning on Windows#9634
bsipocz merged 1 commit into
astropy:masterfrom
pllim:win-cache-warn

Conversation

@pllim

@pllim pllim commented Nov 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This pull request is to address cache warning seen on Windows testing.

Follow up of #7928 and needs to be addressed as part of #9620.

cc @aarchiba

p.s. Not sure why Windows job on Travis CI didn't catch this, but I see it on a local Windows 10 machine.

@pllim pllim added testing utils Affects-dev PRs and issues that do not impact an existing Astropy release Windows labels Nov 19, 2019
@pllim pllim added this to the v4.0 milestone Nov 19, 2019
@pllim
pllim requested a review from bsipocz November 19, 2019 18:56
@aarchiba

aarchiba commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

Is this still necessary?

@pllim

pllim commented Nov 25, 2019

Copy link
Copy Markdown
Member Author

I saw it in 4.0rc1. Has the situation changed?

@aarchiba

aarchiba commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

I'm willing to take a swing at this, but I have no Windows machine to test it on. But I guess if I set up a PR and remove this "ignore" I'll get errors from the specific lines that emit this warning? I can then try to to CI debugging.

@pllim

pllim commented Nov 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

if I set up a PR and remove this "ignore" I'll get errors from the specific lines that emit this warning?

Yes, it would show up as CI failure with a traceback that originated from the warning. I pip installed 4.0rc1 from GitHub tag into a Python 3.7 conda environment. Or maybe I checked out the 4.0rc1 tag from a git clone. Can't remember exactly now!

bsipocz
bsipocz approved these changes Nov 27, 2019
View reviewed changes

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@bsipocz
bsipocz merged commit c3bdd4d into astropy:master Nov 27, 2019
@bsipocz

bsipocz commented Nov 27, 2019

Copy link
Copy Markdown
Member

Thanks @pllim!

@pllim
pllim deleted the win-cache-warn branch November 27, 2019 23:14
This was referenced Nov 28, 2019
Merged
Closed
@aarchiba

aarchiba commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

One of the warnings was concealing a nasty bug (#9704) in astropy.config.paths.set_temp_cache.

@aarchiba

aarchiba commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

In fact I've removed suppression of all the cache-related warnings and CI passes fine - am I doing something wrong in #9703 ?

bsipocz added a commit that referenced this pull request Dec 1, 2019
@bsipocz
Merge pull request #9634 from pllim/win-cache-warn
94545fa 
TST: Ignore cache warning on Windows
@pllim

pllim commented Dec 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Oh... right. In my first review of #9703, I forgot that this warning was local to my machine. Let me double check with your branch...

I can confirm that #9703 cleared the warnings on my machine! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release testing utils Windows

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @aarchiba @bsipocz