Repository navigation
Test for warnings when writing read-only cache - #9575
Merged
Merged
Conversation
pllim
added
the
Affects-dev
pllim
approved these changes
Nov 9, 2019
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
Definitely cleaner than my attempt. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of #7928 and addresses the problem more directly than #9569 . In particular this version tries to ensure that CacheMissingWarnings are raised if and only if the user's intended operation needs to write to a read-only cache. (Or if the user needs to read from a non-existent cache.)