Repository navigation
Change name of table.cstack to dstack - #9566
Merged
Merged
Conversation
taldcroft
added
table
Affects-dev
Member
|
You've suggested I like dstack though, it makes more sense. |
bsipocz
approved these changes
Nov 8, 2019
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
There are still a few instances of cstack mentions, but overall it looks good to me.
$ ~/munka/devel/astropy [:2e9e4e78a|⚑ 26] $ grr -i cstack
astropy/modeling/tests/test_separable.py: _cstack, _arith_oper, separability_matrix)
astropy/modeling/tests/test_separable.py:def test_cstack():
astropy/modeling/tests/test_separable.py: result = _cstack(sh1, scl1)
astropy/modeling/tests/test_separable.py: result = _cstack(sh1, rot)
astropy/modeling/tests/test_separable.py: result = _cstack(rot, sh1)
astropy/modeling/separable.py:def _cstack(left, right):
astropy/modeling/separable.py:_operators = {'&': _cstack, '|': _cdot, '+': _arith_oper, '-': _arith_oper,
astropy/table/tests/test_operations.py:class TestCStack():
Member
Author
|
I believe all the |
Member
|
Re: p.s. Is the parenthesis necessary? |
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Nov 9, 2019
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Nov 10, 2019
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Nov 11, 2019
maxnoe
pushed a commit
to maxnoe/astropy
that referenced
this pull request
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table.cstack()is short for depth-wise stacking, by analogy tovstackandhstack. I don't quite remember why it got namedcstackinstead ofdstack. I think thattable.cstackis conceptually similar tonp.dstack: "Stack arrays in sequence depth wise (along third axis)."Closes #9565