Skip to content

Numpy should not be installed for egg_info tests - #948

Merged
eteq merged 1 commit into
astropy:masterfrom
astrofrog:fix-travis-egg_info
Apr 18, 2013
Merged

eteq merged 1 commit into
astropy:masterfrom
astrofrog:fix-travis-egg_info

Conversation

@astrofrog

Copy link
Copy Markdown
Member

The point of the egg_info tests is to check that 'python setup.py egg_info' works if no other dependencies are installed (as required by pip when using pip requirements files).

…g_info tests is to check that 'python setup.py egg_info' works if no other dependencies are installed.
@embray

embray commented Apr 5, 2013

Copy link
Copy Markdown
Member

I'm confused. It says the Travis build failed. But the Travis build seems to have succeeded?

@astrofrog

Copy link
Copy Markdown
Member Author

It seems to be pointing to the wrong version on Travis, it's pointing to tests in my fork. Weird.

@astrofrog

Copy link
Copy Markdown
Member Author

@eteq

eteq commented Apr 5, 2013

Copy link
Copy Markdown
Member

Yeah, I've seen that before - Travis gets confused if there are two builds with the same SHA in different repos.

The commit itself looks good, though. Probably my fault - I thought we wanted egg_info if numpy is installed, but no other dependencies are (after thinking about it I see you're right, that no deps makes more sense though)

eteq added a commit to eteq/astropy that referenced this pull request Apr 9, 2013
@eteq

eteq commented Apr 9, 2013

Copy link
Copy Markdown
Member

Note that this a fix for this will be included if we update travis to use wheels as discussed in #938

@astrofrog

Copy link
Copy Markdown
Member Author

Ok, so I shouldn't merge this for now?

@eteq

eteq commented Apr 18, 2013

Copy link
Copy Markdown
Member

I suppose there's no harm in merging it, because the conflict resolution is pretty trivial. I'll just merge this now so we have our current tests working correctly until/if #938 is implemetned.

eteq added a commit that referenced this pull request Apr 18, 2013
Numpy should not be installed for egg_info tests
@eteq
eteq merged commit cae3ef2 into astropy:master Apr 18, 2013
eteq added a commit to eteq/astropy that referenced this pull request Apr 26, 2013
@astrofrog
astrofrog deleted the fix-travis-egg_info branch July 5, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants