Docs won't build on Sphinx 1.2b1 due to WCSBase #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem was discussed some in #934 and #908.
Sphinx recently put out v1.2 beta 1 on PyPI - this was killing the travis build, so you can see the error for this in e.g. https://s3.amazonaws.com/archive.travis-ci.org/jobs/5958983/log.txt .
The underlying problem is twofold: First,
WCSBaseis not picklable. Sphinx 1.2b1 tries to pickle it where 1.1.3 did not, and that leads to this failure. The second part is why Sphinx 1.2 is picklingWCSBaseat all. I can't see anything in the sphinx 1.2 changelog that would cause this, so I posted to the sphinx mailing list asking about it (https://groups.google.com/forum/?fromgroups=#!topic/sphinx-users/kpMScxmeMMc).@mdboom - do you have any thoughts here? A workaround might be to make
WCSBasesupport pickling, although I'm not sure how much work that would be.