Skip to content

Remove windows-specific workarounds for mmap. - #9228

Closed
mhvk wants to merge 1 commit into
astropy:masterfrom
mhvk:io-fits-windows-mmap-test
Closed

mhvk wants to merge 1 commit into
astropy:masterfrom
mhvk:io-fits-windows-mmap-test

Conversation

@mhvk

@mhvk mhvk commented Sep 14, 2019 •

Copy link
Copy Markdown
Contributor

There are some work-arounds in hdu_list for windows systems, which are no longer truly functional (see #5797). This PR is an attempt to test whether they are in fact still needed.

@mhvk

mhvk commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

@bsipocz, @astrofrog, @Cadair - I'm trying to test a windows-specific change. Is that still tested by default? I don't see appveyor anymore... If not, how can I test it?

@mhvk

mhvk commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Ah, I see windows is now done on travis. Nice! (and it fails, so useful for the test...)

@mhvk

mhvk commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

closing since the special treatment for windows is clearly still required

@mhvk mhvk closed this Sep 14, 2019
@bsipocz

bsipocz commented Sep 14, 2019

Copy link
Copy Markdown
Member

@mhvk - yes, we're gradually moving away from appveyor in favour of travis and azure depending on the repo (the configs set up by ci-helpers are seriously broken anyway).

@mhvk
mhvk deleted the io-fits-windows-mmap-test branch September 14, 2019 21:45
@mhvk

mhvk commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Ah, thanks. It was nice to see that travis now supports windows.

@pllim

pllim commented Sep 16, 2019

Copy link
Copy Markdown
Member

Re: Windows on Travis -- convenient but very slow. I am hoping we switch to Azure soon, though it is still missing a [skip ci] feature that we use a lot.

@mhvk

mhvk commented Sep 16, 2019

Copy link
Copy Markdown
Contributor Author

My distrust of microsoft prevents me from being too keen on azure... (though really, they have been a bit better in the last decade...)

@bsipocz

bsipocz commented Sep 16, 2019

Copy link
Copy Markdown
Member

They've changed a lot in the past few years. At least that's the generic understanding talking to either insiders or outsiders of the company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants