Ensure that MaskedColumn.data returns a plain MaskedArray. #8855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8855 +/- ##
=========================================
+ Coverage 86.59% 86.99% +0.4%
=========================================
Files 405 400 -5
Lines 60116 59480 -636
Branches 1100 1100
=========================================
- Hits 52056 51745 -311
+ Misses 7419 7094 -325
Partials 641 641
Continue to review full report at Codecov.
|
Previously this was instead a masked_BaseColumn, which caused a number of performance hits, e.g., because slicing would go through multiple rounds of ``__array_finalize__``. This includes a regression check for that count.
mhvk
force-pushed
the
maskedcolumn-data-property
branch
from
0272ae6 to
5f99eef
Compare
|
@taldcroft - as you're upping the performance of |
|
@mhvk - sorry for the delay, this looks great! Only thing is that the 32-bit fails look real, mostly related to Table in some way, but I can't quite connect the dots. |
|
32-bit is fortunately not connected - see #8934 |
taldcroft
left a comment
taldcroft
left a comment
There was a problem hiding this comment.
OK, ignoring the 32-bit fail.
2 participants
Previously this was instead a masked_BaseColumn, which caused a number of performance hits, e.g., because slicing would go through multiple rounds of
__array_finalize__. This PR includes a regression check for that count.fixes #6721