Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8852 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 400 400
Lines 59480 59480
Branches 1100 1100
=======================================
Hits 51745 51745
Misses 7094 7094
Partials 641 641Continue to review full report at Codecov.
|
…ludes a change to 'spawn', for which the fast reader doesn't work.
astrofrog
force-pushed
the
default-fork-method
branch
from
June 15, 2019 18:24
f5720df to
f1c203e
Compare
astrofrog
requested review from
abonaca and
taldcroft
and removed request for
abonaca
June 15, 2019 19:20
Member
Author
|
Maybe we can wait a little to see if the rest of the fixes for #8853 can be identified before merging this. |
Member
Author
|
I fixed the issues with 'spawn' in #8853 so closing this since the workaround is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue described in #8851 - ideally we would fix the underlying cause, but this will at least keep things working once Python 3.8 if we don't.
This will need a changelog entry but I'll wait until the 2.0.15 sections are created in the changelog.