Repository navigation
Additions/cleanup for 3.2 whatsnew - #8805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8805 +/- ##
==========================================
+ Coverage 86.99% 86.99% +<.01%
==========================================
Files 400 400
Lines 59459 59460 +1
Branches 1100 1100
==========================================
+ Hits 51724 51725 +1
Misses 7094 7094
Partials 641 641
Continue to review full report at Codecov.
|
I suppose it is. |
| ============================ | ||
|
|
||
| The new redefinition of the SI system and its base units came into force on May | ||
| 20, 2019. Accompanying that redefinition was a new set of physical constants |
There was a problem hiding this comment.
Please change the middle-endian. Whether to stick with ISO 8601 (according to the astropy style guide to docs) or a more narrative "20 May 2019", I don't mind.
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Nitpick and other stuff from the peanut gallery...
|
|
||
| t = Time('J2018') + np.linspace(-1, 0, 1000)*u.year | ||
|
|
||
| bme_origin = BarycentricMeanEcliptic([0]*len(t)*u.deg, [0]*len(t)*u.deg, equinox=t) |
There was a problem hiding this comment.
Not directly relevant here, but should we consider the fact that we do not just broadcast the coordinates with the times a bug?
There was a problem hiding this comment.
Good point. I was surprised by that, and just accepted it, but if it surprised me maybe I shouldn't have! Will make an issue.
| plt.plot(t.jyear, it.ra.wrap_at(180*u.deg).deg, label='BarycentricTrueEcliptic') | ||
|
|
||
| plt.xlabel('J-year') | ||
| plt.ylabel('ICRS R.A. of ecliptic origin') |
There was a problem hiding this comment.
Only real comment: could you add "(degree)" so that the units are clear?
And maybe for x, "Julian year"
| im = bme_origin.transform_to(ICRS()) | ||
| it = bte_origin.transform_to(ICRS()) | ||
|
|
||
| plt.plot(t.jyear, im.ra.wrap_at(180*u.deg).deg, label='BarycentricMeanEcliptic') |
There was a problem hiding this comment.
Maybe (to instill good habits, since we're showing the source):
from astropy.visualization import quantity_support
quantity_support()
at the top, and then here delete the .deg?
Pity we don't have time_support yet!
There was a problem hiding this comment.
Good point, and I figured I'd demo inferring the unit from the qunatity in the ylabel for good measure!
[docs only]
Additions/cleanup for 3.2 whatsnew
This adds a section to the what's new about CODATA and does some other spiffification and cleanup. Still doesn't have the "but the numbers", but that's part of the release process in my mind (agree @bsipocz ?)