Repository navigation
change placeholder to real what's new message for the ecliptic changes - #8661
Merged
Merged
Conversation
Member
Author
|
Oh, and we may want to try to get in a quick update to the coordinates docs with a bit of this info (separate from the what's new I mean), but I don't have time for that now, and since that's between RC and release it's ok to do a just-docs update (if not ideal...). |
astrojuanlu
reviewed
May 4, 2019
astrojuanlu
approved these changes
May 4, 2019
astrojuanlu
left a comment
astrojuanlu
left a comment
Member
There was a problem hiding this comment.
I left one minor wording comment, but other than that LGTM!
Member
What's the release schedule? I can try to write something on Monday morning I think. |
Member
I hope to get the RC out of the door tomorrow, narrative docs updates are more than welcome even after that. |
Co-Authored-By: eteq <[email protected]>
bsipocz
pushed a commit
that referenced
this pull request
May 6, 2019
change placeholder to real what's new message for the ecliptic changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the what's new entry for the changes mainly introduced in #8394 to actually have "real" content. I think it would be good to have this in the RC so anyone testing it can see what this change is actually about. @Juanlu001 if you have a sec you might want to take a look, but @bsipocz if you want to do the RC I think it's probably best to just merge this then and if @Juanlu001 has changes we can do that between RC and release.