Repository navigation
Fix ecliptic affine transform - #8606
Merged
astrofrog merged 2 commits intoApr 19, 2019
Merged
Conversation
pllim
added
the
Affects-dev
Member
|
Maintainer note: If this gets into 3.2, then it is "affects dev" and does not need a change log. But if this gets milestoned beyond 3.2, then please remove "affects dev" label and consider if change log is necessary. |
eteq
approved these changes
Apr 19, 2019
eteq
left a comment
eteq
left a comment
Member
There was a problem hiding this comment.
Aha, the wonders of Linear Algebra. LGTM!
pllim
added
the
zzz 💤 merge-when-ci-passes
Codecov Report
@@ Coverage Diff @@
## master #8606 +/- ##
==========================================
- Coverage 86.89% 86.86% -0.04%
==========================================
Files 393 393
Lines 58653 58907 +254
Branches 1064 1100 +36
==========================================
+ Hits 50969 51172 +203
- Misses 7065 7094 +29
- Partials 619 641 +22
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #8606 +/- ##
==========================================
- Coverage 86.89% 86.86% -0.04%
==========================================
Files 393 393
Lines 58653 58907 +254
Branches 1064 1100 +36
==========================================
+ Hits 50969 51172 +203
- Misses 7065 7094 +29
- Partials 619 641 +22
Continue to review full report at Codecov.
|
adrn
approved these changes
Apr 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #8394, should be uncontroversial. See also #8601, which thanks to Linear Algebra™ wasn't necessary.